[website] Remove ecashpage div ID
ClosedPublic
Actions

Authored by Mengerian on Sep 28 2021, 20:35.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCWEBadf603cbdf26: [website] Remove ecashpage div ID

Summary

The "ecashpage" ID is undefined, and doesn't seem to do anything.
Remove it in preparation for renaming the various "bcha" tags to "ecash" equivalents.

Test Plan

Built and ran it locally, it looks fine.

Diff Detail

Repository

rABCWEB Bitcoin ABC Website

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Mengerian created this revision.Sep 28 2021, 20:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 28 2021, 20:35

Harbormaster completed remote builds in B16803: Diff 30193.Sep 28 2021, 20:35

Mengerian requested review of this revision.Sep 28 2021, 20:35

bytesofman requested changes to this revision.Sep 28 2021, 22:21

bytesofman added a subscriber: bytesofman.

bytesofman added inline comments.

ecash.html
68 ↗	(On Diff #30193)	Could we get rid of this div for the same reason? If the `bchapage` id is used somewhere, I guess okay to keep...should probably be renamed though.

This revision now requires changes to proceed.Sep 28 2021, 22:21

Mengerian requested review of this revision.Sep 29 2021, 16:05

Mengerian added inline comments.

ecash.html
68 ↗	(On Diff #30193)	Yeah, I was planning to rename to "ecashpage" in a subsequent Diff. This one is defined in the CSS files, and has the effect of centering everything. That's why I wanted to remove the instance above before renaming this one.