Differential D1022

Move urlDecode to where it is used
ClosedPublic
Actions

Authored by deadalnix on Jan 23 2018, 15:55.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Commits

rSTAGINGf71086286661: Move urlDecode to where it is used
rABCf71086286661: Move urlDecode to where it is used

Summary

It has just one call site and is creating circular dependencies betweent he wallet and server libraries.

Test Plan

With and without wallet:

make

Test cmake build:

cmake -GNinja ..
ninja

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 23 2018, 15:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2018, 15:55

Harbormaster completed remote builds in B1739: Diff 2700.Jan 23 2018, 15:55

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix added a child revision: D1023: Add support to build tests with cmake.Jan 23 2018, 16:04

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

schancel accepted this revision.Jan 24 2018, 00:22

This revision is now accepted and ready to land.Jan 24 2018, 00:22

Closed by commit rABCf71086286661: Move urlDecode to where it is used (authored by deadalnix). · Explain WhyJan 24 2018, 00:36

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

httpserver.h

2 lines

httpserver.cpp

12 lines

wallet/

CMakeLists.txt

10 lines

rpcwallet.cpp

15 lines

Diff 2725

View Options

src/httpserver.h

View Options

src/httpserver.cpp

View Options

src/wallet/CMakeLists.txt

View Options

Move urlDecode to where it is usedClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2725

src/httpserver.h

src/httpserver.cpp

src/wallet/CMakeLists.txt

src/wallet/rpcwallet.cpp

Move urlDecode to where it is used
ClosedPublic
Actions

Revision Contents
Changeset List