Differential D10221

[avalanche] Add a notification handler to the peer manager
AbandonedPublic
Actions

Authored by Fabien on Sep 30 2021, 09:40.

Details

Reviewers

None

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Summary

This makes it possible to register observers without creating a dependency from the peer manager. This will be used by the processor to handle the proof conflicts without creating a circular dependency, and without having the peer manager to know about what's done with these conflicting proofs.

This is extracted from D10027.

Ref T1854.

Test Plan

ninja check-avalanche-peermanager_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_conflicting_proof_handler

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16823
Build 33489: Build Diff	build-debug · build-without-wallet · lint-circular-dependencies · build-diff · build-clang · build-clang-tidy
Build 33488: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 30 2021, 09:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2021, 09:40

Fabien requested review of this revision.Sep 30 2021, 09:40

Harbormaster completed remote builds in B16823: Diff 30227.Sep 30 2021, 09:52

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[0m[0;32mrpc_preciousblock.py                    | ✓ Passed  | 1 s
[0m[0;32mrpc_psbt.py                             | ✓ Passed  | 27 s
[0m[0;32mrpc_rawtransaction.py                   | ✓ Passed  | 14 s
[0m[0;32mrpc_scantxoutset.py                     | ✓ Passed  | 3 s
[0m[0;32mrpc_setban.py                           | ✓ Passed  | 2 s
[0m[0;32mrpc_signmessage.py                      | ✓ Passed  | 1 s
[0m[0;32mrpc_signrawtransaction.py               | ✓ Passed  | 1 s
[0m[0;32mrpc_txoutproof.py                       | ✓ Passed  | 2 s
[0m[0;32mrpc_uptime.py                           | ✓ Passed  | 1 s
[0m[0;32mrpc_users.py                            | ✓ Passed  | 6 s
[0m[0;32mrpc_whitelist.py                        | ✓ Passed  | 1 s
[0m[0;32mtool_wallet.py                          | ✓ Passed  | 6 s
[0m[0;32mwallet_abandonconflict.py               | ✓ Passed  | 9 s
[0m[0;32mwallet_address_types.py                 | ✓ Passed  | 15 s
[0m[0;32mwallet_avoidreuse.py                    | ✓ Passed  | 6 s
[0m[0;32mwallet_backup.py                        | ✓ Passed  | 31 s
[0m[0;32mwallet_balance.py                       | ✓ Passed  | 14 s
[0m[0;32mwallet_basic.py                         | ✓ Passed  | 22 s
[0m[0;32mwallet_coinbase_category.py             | ✓ Passed  | 1 s
[0m[0;32mwallet_create_tx.py                     | ✓ Passed  | 7 s
[0m[0;32mwallet_createwallet.py                  | ✓ Passed  | 2 s
[0m[0;32mwallet_createwallet.py --usecli         | ✓ Passed  | 3 s
[0m[0;32mwallet_descriptor.py                    | ✓ Passed  | 17 s
[0m[0;32mwallet_disable.py                       | ✓ Passed  | 1 s
[0m[0;32mwallet_dump.py                          | ✓ Passed  | 6 s
[0m[0;32mwallet_encryption.py                    | ✓ Passed  | 5 s
[0m[0;32mwallet_hd.py                            | ✓ Passed  | 6 s
[0m[0;32mwallet_import_rescan.py                 | ✓ Passed  | 4 s
[0m[0;32mwallet_import_with_label.py             | ✓ Passed  | 1 s
[0m[0;32mwallet_importdescriptors.py             | ✓ Passed  | 7 s
[0m[0;32mwallet_importmulti.py                   | ✓ Passed  | 3 s
[0m[0;32mwallet_importprunedfunds.py             | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool.py                       | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py                 | ✓ Passed  | 2 s
[0m[0;32mwallet_labels.py                        | ✓ Passed  | 1 s
[0m[0;32mwallet_listreceivedby.py                | ✓ Passed  | 36 s
[0m[0;32mwallet_listsinceblock.py                | ✓ Passed  | 4 s
[0m[0;32mwallet_listtransactions.py              | ✓ Passed  | 16 s
[0m[0;32mwallet_multiwallet.py                   | ✓ Passed  | 41 s
[0m[0;32mwallet_multiwallet.py --usecli          | ✓ Passed  | 14 s
[0m[0;32mwallet_reorgsrestore.py                 | ✓ Passed  | 3 s
[0m[0;32mwallet_resendwallettransactions.py      | ✓ Passed  | 4 s
[0m[0;32mwallet_startup.py                       | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py                     | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py --mineblock         | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py               | ✓ Passed  | 1 s
[0m[0;32mwallet_txn_doublespend.py --mineblock   | ✓ Passed  | 3 s
[0m[0;32mwallet_watchonly.py                     | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli            | ✓ Passed  | 1 s
[0m[1m
ALL                                     | ✓ Passed  | 1106 s (accumulated) 
[0mRuntime: 221 s

----------------------------------------------------------------------
Ran 8 tests in 0.009s

OK

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

unrelated failure

Fabien added a child revision: D10222: [avalanche] Let the peermanager select whether a conflicting proof should be preferred.Sep 30 2021, 11:50

This is going to be the last step

Fabien mentioned this in D10222: [avalanche] Let the peermanager select whether a conflicting proof should be preferred.Oct 1 2021, 19:21

Fabien abandoned this revision.Feb 9 2022, 13:27