Paths

Table of Contentst

Differential D10245

[avalanche] Move the vote eror codes to its own enum class
ClosedPublic
Actions

Authored by Fabien on Oct 1 2021, 16:01.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC461b116e804f: [avalanche] Move the vote eror codes to its own enum class

Summary

And remove the BLOCK_ prefix. This will be used for writing tests for conflicting proof votes as well.

Ref T1854.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_voting

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_test_framework_factor_votes

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16863
Build 33566: Build Diff	build-without-wallet · build-clang-tidy · build-diff · build-clang · build-debug
Build 33565: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 1 2021, 16:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2021, 16:01

Fabien requested review of this revision.Oct 1 2021, 16:01

Harbormaster completed remote builds in B16863: Diff 30277.Oct 1 2021, 16:11

PiRK accepted this revision.Oct 4 2021, 12:14

This revision is now accepted and ready to land.Oct 4 2021, 12:14

Closed by commit rABC461b116e804f: [avalanche] Move the vote eror codes to its own enum class (authored by Fabien). · Explain WhyOct 4 2021, 13:52

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC461b116e804f: [avalanche] Move the vote eror codes to its own enum class.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_voting.py

31 lines

test_framework/

messages.py

11 lines

Diff 30277

View Options

test/functional/abc_p2p_avalanche_voting.py