Page MenuHomePhabricator
Differential D10246

added total wallet balanced to saved wallets list
AbandonedPublic
Actions

Authored by kieran709 on Oct 1 2021, 18:11.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Accessing the balance of any saved wallet that contains the state object and displaying it in the saved wallets list.

Test Plan

npm start
navigate to settings page
verify wallets in saved wallets drop down display balance
verify balance is responsive

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sw-balances
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16865
Build 33569: Build Diffcashtab-tests
Build 33568: arc lint + arc unit

Event Timeline

kieran709 created this revision.Oct 1 2021, 18:11
Owners added a reviewer: Restricted Owners Package.Oct 1 2021, 18:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 1 2021, 18:11
kieran709 requested review of this revision.Oct 1 2021, 18:11
Harbormaster completed remote builds in B16865: Diff 30280.Oct 1 2021, 18:14
bytesofman requested changes to this revision.Oct 1 2021, 20:46

Thanks for this diff. It works but requires refinement for display aesthetics, responsiveness, and balance formatting. Since another diff is already in for this change, please abandon this rev and commence work on separate task discussed in Telegram.

Joey

This revision now requires changes to proceed.Oct 1 2021, 20:46
kieran709 abandoned this revision.Oct 14 2021, 22:57

Abandoned per review feedback.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Configure/
13 lines

Diff 30280

View Options

web/cashtab/src/components/Configure/Configure.js

Loading...