Page MenuHomePhabricator

test: use OP_TRUE p2sh address in p2p_permissions
ClosedPublic

Authored by PiRK on Mon, Oct 4, 07:11.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3af59c095289: test: use OP_TRUE p2sh address in p2p_permissions
Summary

In D9906 I used a regular p2pkh address-key pair to avoid using a script. But the script is more convenient and faster (one less signature). This will be used in coming backports.

Test Plan

test/functional/test_runner.py p2p_permissions

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Mon, Oct 4, 07:11

rewrite the scriptSig to make it more explicit that the one byte of the OP_TRUE script is being pushed to the stack.

use a more explicit method to build the scriptSig from the redeemScript

Fabien requested changes to this revision.Wed, Oct 6, 14:03
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/test_framework/address.py
15 ↗(On Diff #30302)

ADDRESS_ECREG_P2SH_OP_TRUE for consistency

This revision now requires changes to proceed.Wed, Oct 6, 14:03

use ADDRESS_ECREG_P2SH_OP_TRUE for consistency

This revision is now accepted and ready to land.Wed, Oct 6, 15:02