Page MenuHomePhabricator
Differential D10247

test: use OP_TRUE p2sh address in p2p_permissions
ClosedPublic
Actions

Authored by PiRK on Oct 4 2021, 07:11.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3af59c095289: test: use OP_TRUE p2sh address in p2p_permissions
Summary

In D9906 I used a regular p2pkh address-key pair to avoid using a script. But the script is more convenient and faster (one less signature). This will be used in coming backports.

Test Plan

test/functional/test_runner.py p2p_permissions

Diff Detail

Repository
rABC Bitcoin ABC
Branch
op_true_address
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16913
Build 33664: Build Diffbuild-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 33663: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 4 2021, 07:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2021, 07:11
PiRK requested review of this revision.Oct 4 2021, 07:11
Harbormaster completed remote builds in B16867: Diff 30284.Oct 4 2021, 07:27
PiRK updated this revision to Diff 30285.Oct 4 2021, 08:45

rewrite the scriptSig to make it more explicit that the one byte of the OP_TRUE script is being pushed to the stack.

Harbormaster completed remote builds in B16868: Diff 30285.Oct 4 2021, 09:03
PiRK updated this revision to Diff 30302.Oct 5 2021, 08:19

use a more explicit method to build the scriptSig from the redeemScript

Harbormaster completed remote builds in B16880: Diff 30302.Oct 5 2021, 08:33
PiRK mentioned this in D10199: test: Mockwallet.Oct 5 2021, 14:32
Fabien requested changes to this revision.Oct 6 2021, 14:03
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/test_framework/address.py
15 ↗(On Diff #30302)

ADDRESS_ECREG_P2SH_OP_TRUE for consistency

This revision now requires changes to proceed.Oct 6 2021, 14:03
PiRK updated this revision to Diff 30348.Oct 6 2021, 14:20

use ADDRESS_ECREG_P2SH_OP_TRUE for consistency

Harbormaster completed remote builds in B16913: Diff 30348.Oct 6 2021, 14:35
Fabien accepted this revision.Oct 6 2021, 15:02
This revision is now accepted and ready to land.Oct 6 2021, 15:02
Closed by commit rABC3af59c095289: test: use OP_TRUE p2sh address in p2p_permissions (authored by PiRK). · Explain WhyOct 6 2021, 16:40
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC3af59c095289: test: use OP_TRUE p2sh address in p2p_permissions.

Revision Contents
Changeset List

PathSize
test/
functional/
21 lines
test_framework/
2 lines

Diff 30348

View Options

test/functional/p2p_permissions.py

Loading...
View Options

test/functional/test_framework/address.py

Loading...