Page MenuHomePhabricator

[avalanche] Extract the vote status in an enum class
ClosedPublic

Authored by Fabien on Mon, Oct 4, 13:06.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCa331135a588f: [avalanche] Extract the vote status in an enum class
Summary

This moves the Status enum out of the BlockUpdate class. This makes it possible to use the same status values for conflicting proofs. Another diff will extract an API from BlockUpdate to make it possilble to build a ProofUpdate class sharing the same interface.

VoteStatus is an enum class and cannot have an operator<<() method, so we need to update the tests to use BOOST_CHECK instead of BOOST_CHECK_EQUAL. Apart from this there is no change in behavior.

Ref T1854.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable