test: MiniWallet: Default fee_rate in send_self_transfer, Pass in utxo_to_spend
ClosedPublic
Actions

Authored by PiRK on Oct 5 2021, 16:12.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCe4d167592b36: test: MiniWallet: Default fee_rate in send_self_transfer, Pass in utxo_to_spend

Summary

Adds two new features to MiniWallet:

The fee rate is irrelevant sometimes, so just set an arbitrary default
The utxo to spend needs to be selected manually sometimes

This is a backport of core#19922 [1/4]
https://github.com/bitcoin/bitcoin/pull/19922/commits/faba790bd40b5a9e8849997785020790ff60571b

Depends on D10199

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16887
Build 33613: Build Diff	build-diff · build-without-wallet · build-debug · build-clang-tidy · build-clang
Build 33612: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 5 2021, 16:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2021, 16:12

PiRK requested review of this revision.Oct 5 2021, 16:12

PiRK added a child revision: D10255: test: Run rpc_txoutproof.py even with wallet disabled.

Harbormaster completed remote builds in B16887: Diff 30319.Oct 5 2021, 16:27

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[0m[0;32mrpc_signmessage.py                      | ✓ Passed  | 1 s
[0m[0;32mrpc_signrawtransaction.py               | ✓ Passed  | 1 s
[0m[0;32mrpc_txoutproof.py                       | ✓ Passed  | 2 s
[0m[0;32mrpc_uptime.py                           | ✓ Passed  | 1 s
[0m[0;32mrpc_users.py                            | ✓ Passed  | 5 s
[0m[0;32mrpc_whitelist.py                        | ✓ Passed  | 1 s
[0m[0;32mtool_wallet.py                          | ✓ Passed  | 4 s
[0m[0;32mwallet_abandonconflict.py               | ✓ Passed  | 7 s
[0m[0;32mwallet_address_types.py                 | ✓ Passed  | 12 s
[0m[0;32mwallet_avoidreuse.py                    | ✓ Passed  | 4 s
[0m[0;32mwallet_avoidreuse.py --descriptors      | ✓ Passed  | 5 s
[0m[0;32mwallet_backup.py                        | ✓ Passed  | 29 s
[0m[0;32mwallet_balance.py                       | ✓ Passed  | 27 s
[0m[0;32mwallet_basic.py                         | ✓ Passed  | 17 s
[0m[0;32mwallet_coinbase_category.py             | ✓ Passed  | 1 s
[0m[0;32mwallet_create_tx.py                     | ✓ Passed  | 5 s
[0m[0;32mwallet_createwallet.py                  | ✓ Passed  | 2 s
[0m[0;32mwallet_createwallet.py --usecli         | ✓ Passed  | 2 s
[0m[0;32mwallet_descriptor.py                    | ✓ Passed  | 6 s
[0m[0;32mwallet_disable.py                       | ✓ Passed  | 1 s
[0m[0;32mwallet_dump.py                          | ✓ Passed  | 5 s
[0m[0;32mwallet_encryption.py                    | ✓ Passed  | 5 s
[0m[0;32mwallet_encryption.py --descriptors      | ✓ Passed  | 5 s
[0m[0;32mwallet_hd.py                            | ✓ Passed  | 6 s
[0m[0;32mwallet_hd.py --descriptors              | ✓ Passed  | 5 s
[0m[0;32mwallet_import_rescan.py                 | ✓ Passed  | 4 s
[0m[0;32mwallet_import_with_label.py             | ✓ Passed  | 1 s
[0m[0;32mwallet_importdescriptors.py             | ✓ Passed  | 6 s
[0m[0;32mwallet_importmulti.py                   | ✓ Passed  | 3 s
[0m[0;32mwallet_importprunedfunds.py             | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool.py                       | ✓ Passed  | 3 s
[0m[0;32mwallet_keypool_topup.py                 | ✓ Passed  | 2 s
[0m[0;32mwallet_keypool_topup.py --descriptors   | ✓ Passed  | 3 s
[0m[0;32mwallet_labels.py                        | ✓ Passed  | 2 s
[0m[0;32mwallet_labels.py --descriptors          | ✓ Passed  | 2 s
[0m[0;32mwallet_listreceivedby.py                | ✓ Passed  | 12 s
[0m[0;32mwallet_listsinceblock.py                | ✓ Passed  | 5 s
[0m[0;32mwallet_listtransactions.py              | ✓ Passed  | 14 s
[0m[0;32mwallet_multiwallet.py                   | ✓ Passed  | 39 s
[0m[0;32mwallet_multiwallet.py --usecli          | ✓ Passed  | 11 s
[0m[0;32mwallet_reorgsrestore.py                 | ✓ Passed  | 3 s
[0m[0;32mwallet_resendwallettransactions.py      | ✓ Passed  | 13 s
[0m[0;32mwallet_startup.py                       | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py                     | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_clone.py --mineblock         | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py               | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_doublespend.py --mineblock   | ✓ Passed  | 3 s
[0m[0;32mwallet_watchonly.py                     | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli            | ✓ Passed  | 1 s
[0m[1m
ALL                                     | ✓ Passed  | 1035 s (accumulated) 
[0mRuntime: 208 s

----------------------------------------------------------------------
Ran 8 tests in 0.009s

OK

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

PiRK edited the summary of this revision. (Show Details)Oct 6 2021, 14:07

unrelated failure

Fabien accepted this revision.Oct 6 2021, 14:55

This revision is now accepted and ready to land.Oct 6 2021, 14:55

PiRK edited the summary of this revision. (Show Details)Oct 11 2021, 07:06

PiRK added a parent revision: D10199: test: Mockwallet.

This revision was landed with ongoing or failed builds.Oct 11 2021, 07:25

Closed by commit rABCe4d167592b36: test: MiniWallet: Default fee_rate in send_self_transfer, Pass in utxo_to_spend (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain Why

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe4d167592b36: test: MiniWallet: Default fee_rate in send_self_transfer, Pass in utxo_to_spend.