Paths

Table of Contentst

Differential D10264

[rpc] add snake case aliases for transaction methods
ClosedPublic
Actions

Authored by PiRK on Oct 6 2021, 11:20.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC3ed98b036f03: [rpc] add snake case aliases for transaction methods

Summary

This is a backport of core#16378 [2/3]
https://github.com/bitcoin/bitcoin/pull/16378/commits/2c2a1445dc9d22c9d729b8301c8b3f54195bcfcf

Depends on D10263

I also added "fee_rate", because I will use it in the next commit instead of conf_target and estimate_mode to set the fee.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 6 2021, 11:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 6 2021, 11:20

PiRK requested review of this revision.Oct 6 2021, 11:20

PiRK edited the summary of this revision. (Show Details)Oct 6 2021, 11:22

PiRK added a parent revision: D10263: [rpc] walletcreatefundedpsbt: allow inputs to be null.

PiRK added a child revision: D10265: [rpc] add send method.Oct 6 2021, 11:22

PiRK edited the summary of this revision. (Show Details)Oct 6 2021, 11:22

teamcity edited the summary of this revision. (Show Details)Oct 6 2021, 11:34

Harbormaster completed remote builds in B16900: Diff 30334.Oct 6 2021, 11:44

fix fee_rate: it was ignored because I forgot to update an if statement

Harbormaster completed remote builds in B16902: Diff 30336.Oct 6 2021, 12:17

Fabien accepted this revision.Oct 6 2021, 14:23

This revision is now accepted and ready to land.Oct 6 2021, 14:23

Fabien requested changes to this revision.Oct 6 2021, 14:27

Fabien added inline comments.

src/wallet/rpcwallet.cpp
3706 ↗	(On Diff #30336)	The type here is probably wrong, and so is the above comment. Can you check and update accordingly ?

This revision now requires changes to proceed.Oct 6 2021, 14:27

Fabien mentioned this in D10265: [rpc] add send method.Oct 6 2021, 14:52

rebase

After checking, there is a special RPCArg::Type type for amounts, but not a special UniValue::VType. The amount type is later checked in AmountFromValue.

Harbormaster completed remote builds in B16920: Diff 30363.Oct 7 2021, 07:50

Fabien accepted this revision.Oct 7 2021, 08:02

This revision is now accepted and ready to land.Oct 7 2021, 08:02

Closed by commit rABC3ed98b036f03: [rpc] add snake case aliases for transaction methods (authored by Sjors Provoost <sjors@sprovoost.nl>, committed by PiRK). · Explain WhyOct 7 2021, 12:57

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC3ed98b036f03: [rpc] add snake case aliases for transaction methods.

Revision Contents
Changeset List

Path

Size

src/

wallet/

59 lines

test/

functional/

rpc_fundrawtransaction.py

2 lines

Diff 30371

src/wallet/rpcwallet.cpp

Loading...

test/functional/rpc_fundrawtransaction.py

Loading...