Page MenuHomePhabricator

[rpc] add snake case aliases for transaction methods
ClosedPublic

Authored by PiRK on Wed, Oct 6, 11:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3ed98b036f03: [rpc] add snake case aliases for transaction methods
Summary

This is a backport of core#16378 [2/3]
https://github.com/bitcoin/bitcoin/pull/16378/commits/2c2a1445dc9d22c9d729b8301c8b3f54195bcfcf

Depends on D10263

I also added "fee_rate", because I will use it in the next commit instead of conf_target and estimate_mode to set the fee.

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Wed, Oct 6, 11:20

fix fee_rate: it was ignored because I forgot to update an if statement

This revision is now accepted and ready to land.Wed, Oct 6, 14:23
Fabien requested changes to this revision.Wed, Oct 6, 14:27
Fabien added inline comments.
src/wallet/rpcwallet.cpp
3706 ↗(On Diff #30336)

The type here is probably wrong, and so is the above comment. Can you check and update accordingly ?

This revision now requires changes to proceed.Wed, Oct 6, 14:27

After checking, there is a special RPCArg::Type type for amounts, but not a special UniValue::VType. The amount type is later checked in AmountFromValue.

This revision is now accepted and ready to land.Thu, Oct 7, 08:02