Page MenuHomePhabricator

Use std::unique_ptr for CZMQNotifierFactory.
ClosedPublic

Authored by PiRK on Fri, Oct 8, 11:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7a143c308625: Use std::unique_ptr for CZMQNotifierFactory.
Summary

Instead of returning a raw pointer from CZMQNotifierFactory and
implicitly requiring the caller to know that it has to take ownership,
return a std::unique_ptr to make this explicit.

This also changes the typedef for CZMQNotifierFactory to use the new
C++11 using syntax, which makes it (a little) less cryptic.

This is a backport of core#13686 [3/5]
https://github.com/bitcoin/bitcoin/pull/13686/commits/7f2ad1b9acef4ccc1b3e1a9f551416235d95cbfd

Depends on D10283

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable