Page MenuHomePhabricator

test: remove copy-pasted tip() function when unused
ClosedPublic

Authored by PiRK on Mon, Oct 11, 07:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC46925b6bd540: test: remove copy-pasted tip() function when unused
Summary

Remove the tip() function in abc_ tests when it is unused or used only once (set the attribute directly).

When the function is used multiple times in a test, make it a method and rename it to set_tip().

Test Plan

test/functional/test_runner.py abc*

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Mon, Oct 11, 07:54
PiRK retitled this revision from tests: clean up tip() function to test: copy-pasted tip() function when unused.Mon, Oct 11, 11:49
This revision is now accepted and ready to land.Mon, Oct 11, 13:15
PiRK retitled this revision from test: copy-pasted tip() function when unused to test: remove copy-pasted tip() function when unused.Mon, Oct 11, 19:10