Page MenuHomePhabricator
Differential D10297

test: remove copy-pasted tip() function when unused
ClosedPublic
Actions

Authored by PiRK on Oct 11 2021, 07:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC46925b6bd540: test: remove copy-pasted tip() function when unused
Summary

Remove the tip() function in abc_ tests when it is unused or used only once (set the attribute directly).

When the function is used multiple times in a test, make it a method and rename it to set_tip().

Test Plan

test/functional/test_runner.py abc*

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 11 2021, 07:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 11 2021, 07:54
PiRK requested review of this revision.Oct 11 2021, 07:54
PiRK edited the summary of this revision. (Show Details)Oct 11 2021, 07:57
Harbormaster completed remote builds in B16952: Diff 30414.Oct 11 2021, 08:14
PiRK retitled this revision from tests: clean up tip() function to test: copy-pasted tip() function when unused.Oct 11 2021, 11:49
Fabien accepted this revision.Oct 11 2021, 13:15
This revision is now accepted and ready to land.Oct 11 2021, 13:15
PiRK retitled this revision from test: copy-pasted tip() function when unused to test: remove copy-pasted tip() function when unused.Oct 11 2021, 19:10
Closed by commit rABC46925b6bd540: test: remove copy-pasted tip() function when unused (authored by PiRK). · Explain WhyOct 11 2021, 19:46
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC46925b6bd540: test: remove copy-pasted tip() function when unused.

Revision Contents
Changeset List

Diff 30428

View Options

test/functional/abc-invalid-chains.py

Loading...
View Options

test/functional/abc-mempool-coherence-on-activations.py

Loading...
View Options

test/functional/abc-replay-protection.py

Loading...
View Options

test/functional/abc-segwit-recovery.py

Loading...
View Options

test/functional/abc-transaction-ordering.py

Loading...
View Options

test/functional/abc_p2p_compactblocks.py

Loading...
View Options

test/functional/abc_p2p_fullblocktest.py

Loading...