Page MenuHomePhabricator
Differential D10306

Add functional tests for zmq sequence topic and mempool sequence logic
ClosedPublic
Actions

Authored by PiRK on Oct 12 2021, 08:33.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC18db6565c06e: Add functional tests for zmq sequence topic and mempool sequence logic
Summary

This is a backport of core#19572 [3/4]
https://github.com/bitcoin/bitcoin/pull/19572/commits/68c3c7e1bdd00bbe7d70592a8eb39520fa3f87f1

The main change from the original PR is the removal of the RBF tests.

Depends on D10304

Test Plan

test/functional/test_runner.py interface_zmq

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 12 2021, 08:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2021, 08:34
PiRK requested review of this revision.Oct 12 2021, 08:34
teamcity edited the summary of this revision. (Show Details)Oct 12 2021, 08:34
PiRK added a child revision: D10307: Update zmq notification documentation and sample consumer.Oct 12 2021, 08:41
Harbormaster completed remote builds in B16965: Diff 30434.Oct 12 2021, 09:19
Fabien requested changes to this revision.Oct 12 2021, 09:48
Fabien added a subscriber: Fabien.

You just happened to remove all the tests for the tx removal case. You need to find a way to test this

This revision now requires changes to proceed.Oct 12 2021, 09:48
PiRK added a comment.Oct 12 2021, 11:41
In D10306#231653, @Fabien wrote:

You just happened to remove all the tests for the tx removal case. You need to find a way to test this

Yes. I'm working on it.

PiRK mentioned this in D10311: test: test mempool rejection in interface_zmq.py.Oct 12 2021, 12:44
PiRK requested review of this revision.Oct 12 2021, 12:45

Test added for a tx removal in D10311

Fabien requested changes to this revision.Oct 13 2021, 13:12

see https://reviews.bitcoinabc.org/D10311#inline-48562

This revision now requires changes to proceed.Oct 13 2021, 13:12
PiRK updated this revision to Diff 30488.Oct 13 2021, 13:16

remove RBF related comment

Harbormaster completed remote builds in B16997: Diff 30488.Oct 13 2021, 13:28
PiRK updated this revision to Diff 30489.Oct 13 2021, 14:33

remove more RBF/bumpfee comments discovered while working on D10311

Harbormaster completed remote builds in B16998: Diff 30489.Oct 13 2021, 14:48
Fabien accepted this revision.Oct 13 2021, 15:39
This revision is now accepted and ready to land.Oct 13 2021, 15:39
Closed by commit rABC18db6565c06e: Add functional tests for zmq sequence topic and mempool sequence logic (authored by Gregory Sanders <gsanders87@gmail.com>, committed by PiRK). · Explain WhyOct 14 2021, 06:23
This revision was automatically updated to reflect the committed changes.
PiRK mentioned this in rABC0f144de39fd3: test: test mempool rejection in interface_zmq.py.
PiRK added a commit: rABC18db6565c06e: Add functional tests for zmq sequence topic and mempool sequence logic.

Revision Contents
Changeset List

PathSize
test/
functional/
341 lines

Diff 30510

View Options

test/functional/interface_zmq.py

Loading...