Page MenuHomePhabricator

Add functional tests for zmq sequence topic and mempool sequence logic
ClosedPublic

Authored by PiRK on Tue, Oct 12, 08:33.

Details

Summary

This is a backport of core#19572 [3/4]
https://github.com/bitcoin/bitcoin/pull/19572/commits/68c3c7e1bdd00bbe7d70592a8eb39520fa3f87f1

The main change from the original PR is the removal of the RBF tests.

Depends on D10304

Test Plan

test/functional/test_runner.py interface_zmq

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Tue, Oct 12, 08:34
Fabien requested changes to this revision.Tue, Oct 12, 09:48
Fabien added a subscriber: Fabien.

You just happened to remove all the tests for the tx removal case. You need to find a way to test this

This revision now requires changes to proceed.Tue, Oct 12, 09:48

You just happened to remove all the tests for the tx removal case. You need to find a way to test this

Yes. I'm working on it.

PiRK requested review of this revision.Tue, Oct 12, 12:45

Test added for a tx removal in D10311

This revision now requires changes to proceed.Wed, Oct 13, 13:12

remove RBF related comment

remove more RBF/bumpfee comments discovered while working on D10311

This revision is now accepted and ready to land.Wed, Oct 13, 15:39