Page MenuHomePhabricator
Differential D10308

contrib: correct version check
ClosedPublic
Actions

Authored by PiRK on Oct 12 2021, 08:47.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5b71c10db3f7: contrib: correct version check
Summary

[ not(major >= 3 and minor >= 6) ] fails for '4.0'

This is a backport of core#13699

D1120 introduced f-strings which require python >= 3.6

Test Plan

Run contrib/zmq/zmq_pub.py with python >= 3.6 and verify that it doesn't print the error message about the python version.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr19963
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16967
Build 33770: Build Diff
Build 33769: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 12 2021, 08:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 12 2021, 08:47
PiRK requested review of this revision.Oct 12 2021, 08:47
Harbormaster completed remote builds in B16967: Diff 30441.Oct 12 2021, 08:47
teamcity edited the summary of this revision. (Show Details)Oct 12 2021, 08:47
Fabien accepted this revision.Oct 12 2021, 09:53
This revision is now accepted and ready to land.Oct 12 2021, 09:53
Closed by commit rABC5b71c10db3f7: contrib: correct version check (authored by PiRK). · Explain WhyOct 14 2021, 06:23
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC5b71c10db3f7: contrib: correct version check.

Revision Contents
Changeset List

PathSize
contrib/
zmq/
4 lines

Diff 30441

View Options

contrib/zmq/zmq_sub.py

Loading...