fix CRPCCommand args in rpcwallet.cpp
ClosedPublic
Actions

Authored by PiRK on Oct 14 2021, 09:50.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc2cf6cba845d: fix CRPCCommand args in rpcwallet.cpp

Summary

While backporting core#19994, I ran into two failing assertions:

our version of getrawchangeaddress does not have an "address_type" argument
the "hexstring" for signrawtransactionwithwallet has a typo

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 14 2021, 09:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 14 2021, 09:51

PiRK requested review of this revision.Oct 14 2021, 09:51

teamcity edited the summary of this revision. (Show Details)Oct 14 2021, 09:51

PiRK added a child revision: D10341: Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet).Oct 14 2021, 09:52

Harbormaster completed remote builds in B17019: Diff 30525.Oct 14 2021, 10:06

Fabien accepted this revision.Oct 14 2021, 11:50

This revision is now accepted and ready to land.Oct 14 2021, 11:50

Closed by commit rABCc2cf6cba845d: fix CRPCCommand args in rpcwallet.cpp (authored by PiRK). · Explain WhyOct 14 2021, 15:43

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc2cf6cba845d: fix CRPCCommand args in rpcwallet.cpp.

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

4 lines

Diff 30546

View Options

fix CRPCCommand args in rpcwallet.cppClosedPublicActions