test: use explicit p2p objects where available
ClosedPublic
Actions

Authored by PiRK on Oct 14 2021, 14:00.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1217912166b1: test: use explicit p2p objects where available

Summary

To make the intent of the tests easier to understand, we reference the
p2p connection objects by their explicit names instead of the p2ps array.

This is a backport of core#20022

Test Plan

test/functional/test_runner.py p2p_getdata wallet_resendwallettransactions

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 14 2021, 14:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 14 2021, 14:01

PiRK requested review of this revision.Oct 14 2021, 14:01

teamcity edited the summary of this revision. (Show Details)Oct 14 2021, 14:01

Harbormaster completed remote builds in B17024: Diff 30538.Oct 14 2021, 14:11

Fabien accepted this revision.Oct 14 2021, 15:16

This revision is now accepted and ready to land.Oct 14 2021, 15:16

Closed by commit rABC1217912166b1: test: use explicit p2p objects where available (authored by Oliver Gugger <gugger@gmail.com>, committed by PiRK). · Explain WhyOct 14 2021, 15:44

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1217912166b1: test: use explicit p2p objects where available.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p_getdata.py

2 lines

wallet_resendwallettransactions.py

2 lines

Diff 30548

View Options

test/functional/p2p_getdata.py