Paths

Table of Contentst

Differential D10349

[avalanche] Convert the test utils to use proof shared pointers
ClosedPublic
Actions

Authored by Fabien on Oct 14 2021, 15:55.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABCf4a939da3827: [avalanche] Convert the test utils to use proof shared pointers

Summary

This is what is used almost everywhere in the API, so converting the test facilities removes the need for a lot of std::make_shared<Proof>().

Note that buildRandomProofRef would be a better name after D10342, so I didn't rename the function in this diff.

Ref T1854.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 14 2021, 15:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 14 2021, 15:55

Fabien requested review of this revision.Oct 14 2021, 15:55

Fabien mentioned this in D10342: [avalanche] Introduce ProofRef as an alias for std::shared_ptr<Proof>.Oct 14 2021, 16:02

Fabien edited the summary of this revision. (Show Details)Oct 14 2021, 16:03

Fabien added a child revision: D10342: [avalanche] Introduce ProofRef as an alias for std::shared_ptr<Proof>.

Harbormaster completed remote builds in B17031: Diff 30552.Oct 14 2021, 16:26

deadalnix accepted this revision.Oct 14 2021, 16:32

This revision is now accepted and ready to land.Oct 14 2021, 16:32

Closed by commit rABCf4a939da3827: [avalanche] Convert the test utils to use proof shared pointers (authored by Fabien). · Explain WhyOct 14 2021, 18:56

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf4a939da3827: [avalanche] Convert the test utils to use proof shared pointers.

Fabien removed a child revision: D10342: [avalanche] Introduce ProofRef as an alias for std::shared_ptr<Proof>.Oct 15 2021, 07:51

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

delegation_tests.cpp

13 lines

peermanager_tests.cpp

26 lines

processor_tests.cpp

2 lines

proof_tests.cpp

6 lines

proofcomparator_tests.cpp

14 lines

util.h

7 lines

util.cpp

8 lines

Diff 30558

View Options

src/avalanche/test/delegation_tests.cpp

View Options

src/avalanche/test/peermanager_tests.cpp

View Options

src/avalanche/test/processor_tests.cpp

View Options

src/avalanche/test/proof_tests.cpp

View Options

src/avalanche/test/proofcomparator_tests.cpp

View Options

src/avalanche/test/util.h

View Options

src/avalanche/test/util.cpp

[avalanche] Convert the test utils to use proof shared pointersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30558

src/avalanche/test/delegation_tests.cpp

src/avalanche/test/peermanager_tests.cpp

src/avalanche/test/processor_tests.cpp

src/avalanche/test/proof_tests.cpp

src/avalanche/test/proofcomparator_tests.cpp

src/avalanche/test/util.h

src/avalanche/test/util.cpp

[avalanche] Convert the test utils to use proof shared pointers
ClosedPublic
Actions

Revision Contents
Changeset List