HomePhabricator

[avalanche] Convert the test utils to use proof shared pointers

Description

[avalanche] Convert the test utils to use proof shared pointers

Summary:
This is what is used almost everywhere in the API, so converting the test facilities removes the need for a lot of std::make_shared<Proof>().

Note that buildRandomProofRef would be a better name after D10342, so I didn't rename the function in this diff.

Ref T1854.

Test Plan:

ninja check

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Maniphest Tasks: T1854

Differential Revision: https://reviews.bitcoinabc.org/D10349

Details

Provenance
FabienAuthored on Oct 14 2021, 15:47
FabienPushed on Oct 14 2021, 18:55
Reviewer
Restricted Project
Differential Revision
D10349: [avalanche] Convert the test utils to use proof shared pointers
Parents
rABCefb0b41bf04d: Use using instead of typedef for CTransactionRef
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task