Page MenuHomePhabricator
Differential D10359

[avalanche] Decode the payout script and proof signature in the decodeavalancheproof RPC
ClosedPublic
Actions

Authored by Fabien on Oct 15 2021, 16:00.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC0302976a96a1: [avalanche] Decode the payout script and proof signature in the…
Summary

This is only available when the legacy format is not used.

Ref T1676.

Depends on D10358.

Test Plan
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_decode_payoutscript
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17050
Build 33933: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 33932: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 15 2021, 16:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2021, 16:00
Fabien requested review of this revision.Oct 15 2021, 16:00
Fabien edited the summary of this revision. (Show Details)Oct 15 2021, 16:01
Fabien added a parent revision: D10358: [avalanche] Split the AvalancheProof class into legacy and regular in the test framework.
Fabien removed a parent revision: D10327: [avalanche] Refactor the vote records to inv extraction loop.
Harbormaster completed remote builds in B17050: Diff 30580.Oct 15 2021, 16:27
deadalnix requested changes to this revision.Oct 15 2021, 20:43
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/avalanche/proof.h
149

This makes a copy of the script. that does not seem necessary nor judicious.

This revision now requires changes to proceed.Oct 15 2021, 20:43
Fabien edited the summary of this revision. (Show Details)Oct 18 2021, 20:30
Fabien removed a parent revision: D10358: [avalanche] Split the AvalancheProof class into legacy and regular in the test framework.
Fabien updated this revision to Diff 30602.Oct 18 2021, 20:32
Fabien edited the summary of this revision. (Show Details)
Fabien added a parent revision: D10358: [avalanche] Split the AvalancheProof class into legacy and regular in the test framework.

Always print the payout script, which will be empty in legacy mode.

Harbormaster completed remote builds in B17067: Diff 30602.Oct 18 2021, 20:46
deadalnix accepted this revision.Oct 19 2021, 22:46
This revision is now accepted and ready to land.Oct 19 2021, 22:46
Closed by commit rABC0302976a96a1: [avalanche] Decode the payout script and proof signature in the… (authored by Fabien). · Explain WhyOct 20 2021, 06:45
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC0302976a96a1: [avalanche] Decode the payout script and proof signature in the….

Revision Contents
Changeset List

PathSize
src/
avalanche/
8 lines
rpc/
36 lines
test/
functional/
57 lines

Diff 30580

View Options

src/avalanche/proof.h

Loading...
View Options

src/rpc/avalanche.cpp

Loading...
View Options

test/functional/abc_rpc_avalancheproof.py

Loading...