[avalanche] Check utxos integrity in the peer manager
ClosedPublic
Actions

Authored by Fabien on Oct 20 2021, 15:02.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC57994f2eff21: [avalanche] Check utxos integrity in the peer manager

Summary

This extends the verify() method (testing only) to include a consistency check for the utxos map. This will be useful to make sure we are not making a mess when dealing with conflicting proofs.

Ref T1854.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 20 2021, 15:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2021, 15:02

Fabien requested review of this revision.Oct 20 2021, 15:02

Harbormaster completed remote builds in B17075: Diff 30612.Oct 20 2021, 15:16

deadalnix accepted this revision.Oct 20 2021, 15:26

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/avalanche/peermanager.cpp
429 ↗	(On Diff #30612)	if (it == utxos.end() \|\| it->second != p.peerid) { would have been more elegant

This revision is now accepted and ready to land.Oct 20 2021, 15:26

Fabien added inline comments.Oct 20 2021, 15:49

src/avalanche/peermanager.cpp
429 ↗	(On Diff #30612)	That's on purpose, since it's a testing only method it makes it easier to debug what the problem is (I actually used it that way for my own needs)