This extends the verify() method (testing only) to include a consistency check for the utxos map. This will be useful to make sure we are not making a mess when dealing with conflicting proofs.
Ref T1854.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- rABC57994f2eff21: [avalanche] Check utxos integrity in the peer manager
ninja check-avalanche
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- avalanche_verify_utxos
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 17075 Build 33982: Build Diff build-without-wallet · build-diff · build-debug · lint-circular-dependencies · build-clang-tidy · build-clang Build 33981: arc lint + arc unit
Event Timeline
| src/avalanche/peermanager.cpp | ||
|---|---|---|
| 429 | if (it == utxos.end() || it->second != p.peerid) {would have been more elegant | |
| src/avalanche/peermanager.cpp | ||
|---|---|---|
| 429 | That's on purpose, since it's a testing only method it makes it easier to debug what the problem is (I actually used it that way for my own needs) | |