Page MenuHomePhabricator

TWEAK: Start adding proof-poll responses.
Needs RevisionPublic

Authored by tyler-smith on Oct 23 2021, 05:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Test Plan

ninja all check-all

Diff Detail

Event Timeline

Tail of the build log:

-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[333/510] Building CXX object src/CMakeFiles/util.dir/util/error.cpp.o
[334/510] Building CXX object src/CMakeFiles/util.dir/util/settings.cpp.o
[335/510] Building CXX object src/CMakeFiles/util.dir/util/message.cpp.o
[336/510] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[337/510] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[338/510] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[339/510] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[340/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[341/510] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[342/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[343/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[344/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[345/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[346/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[347/510] Building CXX object src/CMakeFiles/util.dir/util/time.cpp.o
[348/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[349/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[350/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[351/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[352/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[353/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[354/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[355/510] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[356/510] Linking CXX static library src/libutil.a
[357/510] Linking CXX static library src/librpcclient.a
[358/510] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[359/510] Linking CXX static library src/libbitcoinconsensus.a
[360/510] Linking CXX static library src/libscript.a
[361/510] Linking CXX static library src/libcommon.a
[362/510] Linking CXX shared library src/libbitcoinconsensus.so.0.24.4
[363/510] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[364/510] Linking CXX executable src/bitcoin-cli
[365/510] Linking CXX executable src/bitcoin-tx
[366/510] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[367/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[368/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[369/510] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[370/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[371/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[372/510] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqutil.cpp.o
[373/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[374/510] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[375/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[376/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[377/510] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[378/510] Linking CXX static library src/zmq/libzmq.a
[379/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[380/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[381/510] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[382/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[383/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[384/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[385/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[386/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[387/510] Linking CXX static library src/wallet/libwallet.a
[388/510] Linking CXX static library src/wallet/libwallet-tool.a
[389/510] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Tail of the build log:

[310/457] Building CXX object src/CMakeFiles/server.dir/rpc/command.cpp.o
[311/457] Building CXX object src/CMakeFiles/server.dir/pow/pow.cpp.o
[312/457] Building CXX object src/CMakeFiles/server.dir/node/transaction.cpp.o
[313/457] Building CXX object src/CMakeFiles/server.dir/pow/aserti32d.cpp.o
[314/457] Building CXX object src/CMakeFiles/server.dir/net.cpp.o
[315/457] Building CXX object src/CMakeFiles/server.dir/shutdown.cpp.o
[316/457] Building CXX object src/CMakeFiles/server.dir/rpc/abc.cpp.o
[317/457] Building CXX object src/CMakeFiles/server.dir/node/ui_interface.cpp.o
[318/457] Building CXX object src/CMakeFiles/server.dir/script/sigcache.cpp.o
[319/457] Building CXX object src/CMakeFiles/server.dir/script/scriptcache.cpp.o
[320/457] Building CXX object src/CMakeFiles/server.dir/rest.cpp.o
[321/457] Building CXX object src/CMakeFiles/server.dir/timedata.cpp.o
[322/457] Building CXX object src/CMakeFiles/server.dir/rpc/misc.cpp.o
[323/457] Building CXX object src/CMakeFiles/server.dir/versionbits.cpp.o
[324/457] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[325/457] Building CXX object src/CMakeFiles/server.dir/rpc/server.cpp.o
[326/457] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[327/457] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[328/457] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[329/457] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[330/457] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[331/457] Building CXX object src/CMakeFiles/server.dir/dummywallet.cpp.o
[332/457] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[333/457] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[334/457] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[335/457] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[336/457] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[337/457] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[338/457] Linking C static library src/secp256k1/libsecp256k1.a
[339/457] Linking CXX static library src/libcommon.a
[340/457] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[341/457] Linking C executable src/secp256k1/ecmult-bench
[342/457] Linking C executable src/secp256k1/internal-bench
[343/457] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[344/457] Linking C executable src/secp256k1/sign-bench
[345/457] Linking C executable src/secp256k1/verify-bench
[346/457] Linking C executable src/secp256k1/recover-bench
[347/457] Linking CXX static library src/libscript.a
[348/457] Linking CXX static library src/libbitcoinconsensus.a
[349/457] Linking CXX shared library src/libbitcoinconsensus.so.0.24.4
[350/457] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[351/457] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[352/457] Linking CXX executable src/bitcoin-cli
[353/457] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[354/457] Linking CXX executable src/bitcoin-tx
[355/457] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[356/457] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[357/457] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[358/457] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[359/457] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[360/457] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[361/457] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[362/457] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[363/457] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[364/457] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[365/457] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[366/457] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[367/457] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Tail of the build log:

[339/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[340/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[341/510] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[342/510] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[343/510] Linking C static library src/secp256k1/libsecp256k1.a
[344/510] Linking CXX static library src/libbitcoinconsensus.a
[345/510] Linking C executable src/secp256k1/ecmult-bench
[346/510] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[347/510] Linking C executable src/secp256k1/internal-bench
[348/510] Linking C executable src/secp256k1/sign-bench
[349/510] Linking CXX static library src/libscript.a
[350/510] Linking C executable src/secp256k1/verify-bench
[351/510] Linking C executable src/secp256k1/recover-bench
[352/510] Installing component secp256k1
-- Install configuration: "Debug"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[353/510] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[354/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[355/510] Linking CXX static library src/libcommon.a
[356/510] Linking CXX shared library src/libbitcoinconsensus.so.0.24.4
[357/510] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[358/510] Linking CXX executable src/bitcoin-cli
[359/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[360/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[361/510] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[362/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[363/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[364/510] Linking CXX executable src/bitcoin-tx
[365/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[366/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[367/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[368/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[369/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[370/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[371/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[372/510] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[373/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[374/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[375/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[376/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[377/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[378/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[379/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[380/510] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[381/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[382/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[383/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[384/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[385/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[386/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[387/510] Linking CXX static library src/wallet/libwallet.a
[388/510] Linking CXX static library src/wallet/libwallet-tool.a
[389/510] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1

Tail of the build log:

[331/508] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[332/508] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[333/508] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[334/508] Building CXX object src/CMakeFiles/util.dir/interfaces/handler.cpp.o
[335/508] Building CXX object src/CMakeFiles/util.dir/blockdb.cpp.o
[336/508] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[337/508] Building CXX object src/CMakeFiles/util.dir/util/time.cpp.o
[338/508] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[339/508] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[340/508] Building CXX object src/CMakeFiles/util.dir/util/settings.cpp.o
[341/508] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[342/508] Linking CXX static library src/libutil.a
[343/508] Linking CXX static library src/librpcclient.a
[344/508] Linking CXX static library src/libbitcoinconsensus.a
[345/508] Linking CXX static library src/libscript.a
[346/508] Linking CXX static library src/libcommon.a
[347/508] Linking CXX shared library src/libbitcoinconsensus.so.0.24.4
[348/508] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[349/508] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[350/508] Linking CXX executable src/bitcoin-cli
[351/508] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[352/508] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[353/508] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[354/508] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[355/508] Linking CXX executable src/bitcoin-tx
[356/508] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[357/508] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[358/508] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[359/508] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[360/508] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[361/508] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[362/508] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[363/508] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[364/508] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[365/508] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[366/508] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[367/508] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[368/508] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[369/508] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[370/508] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[371/508] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[372/508] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[373/508] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[374/508] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqutil.cpp.o
[375/508] Linking CXX static library src/zmq/libzmq.a
[376/508] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[377/508] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[378/508] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[379/508] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[380/508] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[381/508] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[382/508] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[383/508] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[384/508] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[385/508] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[386/508] Linking CXX static library src/wallet/libwallet.a
[387/508] Linking CXX static library src/wallet/libwallet-tool.a
[388/508] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Tail of the build log:

[339/510] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[340/510] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[341/510] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[342/510] Linking C static library src/secp256k1/libsecp256k1.a
[343/510] Linking CXX static library src/libbitcoinconsensus.a
[344/510] Linking C executable src/secp256k1/ecmult-bench
[345/510] Linking C executable src/secp256k1/internal-bench
[346/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[347/510] Linking C executable src/secp256k1/sign-bench
[348/510] Linking C executable src/secp256k1/verify-bench
[349/510] Linking C executable src/secp256k1/recover-bench
[350/510] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[351/510] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[352/510] Linking CXX static library src/libscript.a
[353/510] Linking CXX static library src/libcommon.a
[354/510] Linking CXX shared library src/libbitcoinconsensus.so.0.24.4
[355/510] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[356/510] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[357/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[358/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[359/510] Linking CXX executable src/bitcoin-cli
[360/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[361/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[362/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[363/510] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[364/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[365/510] Linking CXX executable src/bitcoin-tx
[366/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[367/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[368/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[369/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[370/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[371/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[372/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[373/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[374/510] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[375/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[376/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[377/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[378/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[379/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[380/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[381/510] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[382/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[383/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[384/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[385/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[386/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[387/510] Linking CXX static library src/wallet/libwallet.a
[388/510] Linking CXX static library src/wallet/libwallet-tool.a
[389/510] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
Fabien requested changes to this revision.Oct 25 2021, 07:53
Fabien added a subscriber: Fabien.

If you build using clang you will get thread safety check at build time that can help you figure out what lock is needed.

src/net_processing.cpp
5085 ↗(On Diff #30656)

You need to lock cs_main before you call the lookup method

5130 ↗(On Diff #30656)

You parenthesis are unbalanced

src/net_processing.h
236 ↗(On Diff #30656)

We have strong types for these hashes, see BlockHash and ProofId

This revision now requires changes to proceed.Oct 25 2021, 07:53

Fix build and remove untested code additions.

Fabien requested changes to this revision.Mon, Nov 22, 16:05

Is this is ready to review ? If so:

  • update the title to describe what the diff does, and remove the "TWEAK" prefix which is unnecessary
  • expand in the summary on what problem this is solving, and/or how it relates to the bigger task
This revision now requires changes to proceed.Mon, Nov 22, 16:05