Page MenuHomePhabricator

Send RPC and touch-ups
ClosedPublic

Authored by PiRK on Oct 28 2021, 15:48.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCbe507501c5f7: Send RPC and touch-ups
Summary

Mark send RPC experimental

https://github.com/bitcoin/bitcoin/pull/19969/commits/efc9b85e6f4aa431d308089874a18f0bbdcdd0fd

[rpc] send: various touch-ups

https://github.com/bitcoin/bitcoin/pull/19969/commits/d813d26f06248aaa7be3c698c87939cc777fafd0

The other two commits are not relevant. The second commit of this PR fixed a bug related to RBF, which did not affect us.

This is a backport of core#19969

Test Plan
ninja all check-all

src/bitcoin-cli help send

Event Timeline

PiRK requested review of this revision.Oct 28 2021, 15:48

Tail of the build log:

[400/455] Running utility command for check-bitcoin-timedata_tests
[401/455] bitcoin: testing compilerbug_tests
[402/455] Running utility command for check-bitcoin-validation_flush_tests
[403/455] Running utility command for check-bitcoin-compilerbug_tests
[404/455] bitcoin: testing serialize_tests
[405/455] bitcoin: testing schnorr_tests
[406/455] bitcoin: testing checkpoints_tests
[407/455] Running utility command for check-bitcoin-serialize_tests
[408/455] Running utility command for check-bitcoin-checkpoints_tests
[409/455] Running utility command for check-bitcoin-schnorr_tests
[410/455] Running utility command for check-pow-aserti32d_tests
[411/455] bitcoin: testing validationinterface_tests
[412/455] Running pow test suite
PASSED: pow test suite
[413/455] bitcoin: testing blockstatus_tests
[414/455] bitcoin: testing coinselector_tests
[415/455] Running utility command for check-bitcoin-validationinterface_tests
[416/455] bitcoin: testing wallet_tests
[417/455] Running utility command for check-bitcoin-coinselector_tests
[418/455] Running utility command for check-bitcoin-blockstatus_tests
[419/455] Running utility command for check-bitcoin-wallet_tests
[420/455] bitcoin: testing cashaddr_tests
[421/455] Running utility command for check-bitcoin-cashaddr_tests
[422/455] bitcoin: testing versionbits_tests
[423/455] Running utility command for check-bitcoin-versionbits_tests
[424/455] bitcoin: testing script_tests
[425/455] bitcoin: testing blockcheck_tests
[426/455] Running utility command for check-bitcoin-script_tests
[427/455] Running utility command for check-bitcoin-blockcheck_tests
[428/455] Linking CXX executable src/qt/test/test_bitcoin-qt
[429/455] bitcoin: testing crypto_tests
[430/455] Running utility command for check-bitcoin-crypto_tests
[431/455] bitcoin: testing monolith_opcodes_tests
[432/455] Running utility command for check-bitcoin-monolith_opcodes_tests
[433/455] bitcoin-qt: testing test_bitcoin-qt
[434/455] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[435/455] Building CXX object src/avalanche/test/CMakeFiles/test-avalanche.dir/processor_tests.cpp.o
[436/455] Linking CXX executable src/avalanche/test/test-avalanche
[437/455] avalanche: testing delegation_tests
[438/455] Running utility command for check-avalanche-delegation_tests
[439/455] avalanche: testing proofcomparator_tests
[440/455] Running utility command for check-avalanche-proofcomparator_tests
[441/455] avalanche: testing orphanproofpool_tests
[442/455] Running utility command for check-avalanche-orphanproofpool_tests
[443/455] avalanche: testing proof_tests
[444/455] avalanche: testing peermanager_tests
[445/455] Running utility command for check-avalanche-proof_tests
[446/455] Running utility command for check-avalanche-peermanager_tests
[447/455] avalanche: testing processor_tests
[448/455] Running utility command for check-avalanche-processor_tests
[449/455] Running avalanche test suite
PASSED: avalanche test suite
[450/455] bitcoin: testing coins_tests
[451/455] Running utility command for check-bitcoin-coins_tests
[452/455] secp256k1: testing secp256k1-tests
[453/455] Running secp256k1 test suite
PASSED: secp256k1 test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

remove unneeded newline at the beginning of the description of the help message (see D7184 and D10154)

This revision is now accepted and ready to land.Oct 29 2021, 08:37
This revision was automatically updated to reflect the committed changes.