Page MenuHomePhabricator

[Cashtab] notification duration set as app parameter
ClosedPublic

Authored by kieran709 on Oct 28 2021, 22:22.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC3ac99c4fd2a9: [Cashtab] notification duration set as app parameter
Summary

Added notification duration as parameter in Ticker.js. Related to task T1921

Test Plan

cd web/cashtab
npm start
send XEC, ensure notification duration is correct,
create token, ensure notification duration is correct,
send token, ensure notification duration is correct,
receive XEC, ensure notification duration is correct,
receive token, ensure notification duration is correct,

Diff Detail

Repository
rABC Bitcoin ABC
Branch
notification-duration-parameter
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17134
Build 34099: Build Diffcashtab-tests
Build 34098: arc lint + arc unit

Event Timeline

kieran709 retitled this revision from notification duration set as app parameter to [Cashtab] notification duration set as app parameter.Oct 28 2021, 22:43
bytesofman added inline comments.
web/cashtab/src/components/Common/Notifications.js
122

this one should be currency.notificationDurationLong

This revision now requires changes to proceed.Oct 28 2021, 22:55

responding to review feedback

This revision is now accepted and ready to land.Oct 29 2021, 17:50