- Adds a new function for the user to sign messages using the current active wallet.
- New signPkMessage function in useBCH.js which calls the signMessageWithPrivKey function
- New collapsable form added to Send.js, which then passes BCH, fundingWif and message to useBCH.js, which subsequently calls BCH.BitcoinCash.signMessageWithPrivKey(pk, message) to sign the message and returns the corresponding signature.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC14b62e9817ae: [Cashtab] add message signing function
- npm start
- navigate to the Send tab and un-collapse the Sign Message form
- ensure the Sign Message button is disabled when no input is entered
- ensure the Sign Message button is disabled when input is entered but is then deleted
- ensure the Sign Message button is disabled when input is greater than 150 characters
- input message between 1-150 characters then click the sign message button, okay the dialog and note the successful notification and signature returned
- click on the signature field after a signature has been generated and verify it has copied to clipboard
- without moving away from the same screen, sign another message and ensure the 'Copied to clipboard' message disappears, before clicking on the newly generated signature and verify the new signature is now copied to clipboard
- open electrumABC wallet
- verify signature in the electrumABC wallet
- verify cross browser compatibility in firefox
- npm run extension
- verify the above works in extension mode
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
This is great!
I think the UI needs some tweaks before going live. Not sure if a modal is the best way to do this.
I like the UI on Electrum. Showing 3 fields: message, address, and signature. Then signature is populated after the user clicks "sign."
Reconstruct this in the cashtab collapse. The "Message" field is already there. Create an "address" field that is auto-populated with the active wallet's address. Also add a "signature" field that is only filled out after the user clicks "Sign."
| web/cashtab/src/components/Send/Send.js | ||
|---|---|---|
| 365 ↗ | (On Diff #30719) | Add this notification to src/components/Common/Notifications.js and import it here |
| 378 ↗ | (On Diff #30719) | Use the generic error notification from src/components/Common/Notifications.js |
| 608 ↗ | (On Diff #30719) | I think leaving this at "Sign Message" is best, okay to assume it's with the active wallet |
Comment Actions
Will need to make the "Message" and "signature" fields longer text inputs. Add a copy paste button on the "signature" field.
Comment Actions
- restructured the 'Sign Message' feature to align to the Electrum wallet UI
- moved message signing notification logic into Notifications.js and re-imported into Send.js
- used generic error notification from Notifications.js
- clicking on the Signature Textarea field now acts as a Copy To Clipboard feature
- increased minimum rows to Message and Signature fields for longer text displays
- updated form panel header to 'Sign Message'