Paths

Table of Contentst

Differential D10411

Fix misleading error message: Clean stack rule
ClosedPublic
Actions

Authored by PiRK on Nov 2 2021, 07:48.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe6676216b792: Fix misleading error message: Clean stack rule

Summary

Error messages in cleanstack is misleading as
it lets the user believe that there are extra
elements on stack which is incorrect if the
stack is empty.

This is a backport of core#20006

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr20006

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17155
Build 34141: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang · build-debug · build-clang-tidy
Build 34140: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 2 2021, 07:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 2 2021, 07:48

PiRK requested review of this revision.Nov 2 2021, 07:48

teamcity edited the summary of this revision. (Show Details)Nov 2 2021, 07:48

Harbormaster completed remote builds in B17155: Diff 30723.Nov 2 2021, 08:02

majcosta accepted this revision.Nov 2 2021, 17:43

This revision is now accepted and ready to land.Nov 2 2021, 17:43

Closed by commit rABCe6676216b792: Fix misleading error message: Clean stack rule (authored by sanket1729 <sanket1729@gmail.com>, committed by PiRK). · Explain WhyNov 3 2021, 07:06

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe6676216b792: Fix misleading error message: Clean stack rule.

Revision Contents
Changeset List

Path

Size

src/

script/

script_error.cpp

2 lines

test/

functional/

abc-segwit-recovery.py

2 lines

Diff 30723

src/script/script_error.cpp

Loading...

test/functional/abc-segwit-recovery.py

Loading...