Track keypool entries as internal vs external in memory
ClosedPublic
Actions

Authored by deadalnix on Jan 30 2018, 15:45.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGb3ad82821751: Track keypool entries as internal vs external in memory
rABCb3ad82821751: Track keypool entries as internal vs external in memory

Summary

This resolves a super minor performance regressions in several
keypool-handling functions

Backport core's PR10235

Test Plan

make check
./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 30 2018, 15:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2018, 15:45

Harbormaster completed remote builds in B1767: Diff 2753.Jan 30 2018, 15:45

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

deadalnix added a parent revision: D1041: Make functions in validation.cpp static and pass chainparams.Jan 30 2018, 15:51

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

jasonbcox accepted this revision.Jan 30 2018, 17:02

This revision is now accepted and ready to land.Jan 30 2018, 17:02

deadalnix added a child revision: D1045: Batch flushing operations to the walletdb during top up and increase keypool size..Jan 30 2018, 18:52

Closed by commit rABCb3ad82821751: Track keypool entries as internal vs external in memory (authored by Matt Corallo <git@bluematt.me>, committed by deadalnix). · Explain WhyJan 30 2018, 20:05

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.h

19 lines

wallet.cpp

229 lines

Diff 2760

View Options

src/wallet/wallet.h