Page MenuHomePhabricator

[Cashtab] Auto add latest commit hash to configure
ClosedPublic

Authored by kieran709 on Nov 4 2021, 20:49.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC6f7926708dc2: [Cashtab] Auto add latest commit hash to configure
Summary

Added latest commit hash to the footer of the configure.js component, links to latest commit on github. Related to task T1760.

Test Plan

ensure cashtab is rebased with latest version of master
cd web/cashtab
npm start
in separate terminal run git rev-parse HEAD
take note of latest commit hash
ensure link on configure page matches latest commit hash

npm run extension
load extension
ensure link on configure page matches latest commit hash

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Failed tests logs:

====== CashTab Unit Tests:  Configure without a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure without a wallet 1`

- Snapshot  -  0
+ Received  + 16

@@ -275,6 +275,22 @@
      type="link"
    >
      Documentation
    </a>
    ]
+   <br />
+   <div
+     className="sc-hSdWYo fdXXAb"
+   >
+     <p
+       className="sc-eHgmQL gPThIU"
+     >
+       Source:
+        
+       <a
+         className="sc-dxgOiQ jbuVAx"
+         href="https://reviews.bitcoinabc.org/"
+         type="link"
+       />
+     </p>
+   </div>
  </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:24:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Configure with a wallet ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Configure with a wallet 1`

- Snapshot  -  0
+ Received  + 16

@@ -313,6 +313,22 @@
      type="link"
    >
      Documentation
    </a>
    ]
+   <br />
+   <div
+     className="sc-hSdWYo fdXXAb"
+   >
+     <p
+       className="sc-eHgmQL gPThIU"
+     >
+       Source:
+        
+       <a
+         className="sc-dxgOiQ jbuVAx"
+         href="https://reviews.bitcoinabc.org/"
+         type="link"
+       />
+     </p>
+   </div>
  </div>
    at Object.<anonymous> (/work/web/cashtab/src/components/Configure/__tests__/Configure.test.js:35:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: Configure without a wallet
CashTab Unit Tests: Configure with a wallet

responding to review feedback / updated snapshots

This revision is now accepted and ready to land.Nov 4 2021, 21:07

Builds failing, please check the new dependency is not creating any conflicts and that this has been rebased to the latest master