Paths

Table of Contentst

Differential D10437

rpc: change no wallet loaded message to be clearer
ClosedPublic
Actions

Authored by PiRK on Nov 5 2021, 15:32.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC0a59221f3dea: rpc: change no wallet loaded message to be clearer

Summary

Changes the no wallet is loaded rpc error message to be clearer that no
wallet is loaded and how the user can load or create a wallet. Also
changes the error code from METHOD_NOT_FOUND to RPC_WALLET_NOT_FOUND as
that makes more sense.

This is a backport of core#20101

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr20101

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17197
Build 34225: Build Diff	build-diff · lint-circular-dependencies · build-clang-tidy · build-clang · build-debug · build-without-wallet
Build 34224: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 5 2021, 15:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2021, 15:32

PiRK requested review of this revision.Nov 5 2021, 15:32

teamcity edited the summary of this revision. (Show Details)Nov 5 2021, 15:32

Harbormaster completed remote builds in B17197: Diff 30791.Nov 5 2021, 15:46

Fabien accepted this revision.Nov 5 2021, 19:25

This revision is now accepted and ready to land.Nov 5 2021, 19:25

Closed by commit rABC0a59221f3dea: rpc: change no wallet loaded message to be clearer (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhyNov 9 2021, 08:36

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC0a59221f3dea: rpc: change no wallet loaded message to be clearer.

Revision Contents
Changeset List

Path

Size

src/

wallet/

8 lines

test/

functional/

wallet_multiwallet.py

17 lines

Diff 30791

src/wallet/rpcwallet.cpp

Loading...

test/functional/wallet_multiwallet.py

Loading...