Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC664bafdc0899: [rpc/node] check for high fee before ATMP in clients

Summary

Check absurd fee in BroadcastTransaction and RPC,
return TransactionError::MAX_FEE_EXCEEDED instead
of TxValidationResult::TX_NOT_STANDARD because this
is client preference, not a node-wide policy.

This is a backport of core#19339 [1/3] and core#20109
https://github.com/bitcoin/bitcoin/pull/19339/commits/8f1290c60159a3171c27250bc95687548c5c1b84

Depends on D10463 and D10474

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 11 2021, 09:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 11 2021, 09:31

PiRK requested review of this revision.Nov 11 2021, 09:31

teamcity edited the summary of this revision. (Show Details)Nov 11 2021, 09:32

PiRK added a child revision: D10465: update max-fee-exceeded error message to include RPC.Nov 11 2021, 09:33

remove one of the release notes that belongs to the next commit

Harbormaster completed remote builds in B17232: Diff 30838.Nov 11 2021, 09:52

Harbormaster completed remote builds in B17235: Diff 30841.Nov 11 2021, 10:18

@bot build-master

teamcity awarded a token.Nov 13 2021, 09:39

Fabien requested changes to this revision.Nov 13 2021, 09:47

Fabien added inline comments.

src/node/transaction.cpp
71 ↗	(On Diff #30841)	If ATMP was taking the tx by value, this diff would introduce a crazy remote node crash because of the use after move. After digging a bit: https://github.com/bitcoin/bitcoin/pull/19879