Page MenuHomePhabricator

[rpc/node] check for high fee before ATMP in clients
ClosedPublic

Authored by PiRK on Nov 11 2021, 09:31.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC664bafdc0899: [rpc/node] check for high fee before ATMP in clients
Summary

Check absurd fee in BroadcastTransaction and RPC,
return TransactionError::MAX_FEE_EXCEEDED instead
of TxValidationResult::TX_NOT_STANDARD because this
is client preference, not a node-wide policy.

This is a backport of core#19339 [1/3] and core#20109
https://github.com/bitcoin/bitcoin/pull/19339/commits/8f1290c60159a3171c27250bc95687548c5c1b84

Depends on D10463 and D10474

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Nov 11 2021, 09:31

remove one of the release notes that belongs to the next commit

Fabien requested changes to this revision.Nov 13 2021, 09:47
Fabien added inline comments.
src/node/transaction.cpp
71 ↗(On Diff #30841)

If ATMP was taking the tx by value, this diff would introduce a crazy remote node crash because of the use after move.

After digging a bit: https://github.com/bitcoin/bitcoin/pull/19879

This revision now requires changes to proceed.Nov 13 2021, 09:47
PiRK edited the summary of this revision. (Show Details)

rebase onto D10474 to remove std::move(tx)

This revision is now accepted and ready to land.Nov 16 2021, 14:30

rebase after version number bump

This revision was landed with ongoing or failed builds.Nov 16 2021, 15:56
This revision was automatically updated to reflect the committed changes.