refactor: promote some -netinfo localvars to class members
ClosedPublic
Actions

Authored by PiRK on Nov 23 2021, 14:33.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC47738f027e58: refactor: promote some -netinfo localvars to class members

Summary

This is a backport of core#20002 [4/5]
https://github.com/bitcoin/bitcoin/pull/20002/commits/82fd40216c70037480150d2b62e2b58c57784546

Depends on D10504

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17312
Build 34452: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 34451: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 23 2021, 14:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 23 2021, 14:33

PiRK requested review of this revision.Nov 23 2021, 14:33

teamcity edited the summary of this revision. (Show Details)Nov 23 2021, 14:33

PiRK added a child revision: D10506: refactor: enable -netinfo to add future networks (i2p, cjdns).Nov 23 2021, 14:35

Harbormaster completed remote builds in B17312: Diff 30949.Nov 23 2021, 15:10

Fabien accepted this revision.Nov 23 2021, 15:16

This revision is now accepted and ready to land.Nov 23 2021, 15:16

Closed by commit rABC47738f027e58: refactor: promote some -netinfo localvars to class members (authored by Jon Atack <jon@atack.com>, committed by PiRK). · Explain WhyNov 24 2021, 08:51

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC47738f027e58: refactor: promote some -netinfo localvars to class members.

Revision Contents
Changeset List

Path

Size

src/

bitcoin-cli.cpp

56 lines

Diff 30949

View Options

refactor: promote some -netinfo localvars to class membersClosedPublicActions