Differential D10532

[Cashtab] move newTokenDocumentUrl to Ticker.js
ClosedPublic
Actions

Authored by kieran709 on Nov 24 2021, 17:54.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC34f8eb9f081a: [Cashtab] move newTokenDocumentUrl to Ticker.js

Summary

removed hardcoded cashtab.com fromt CreateTokenForm.js, replaced with parameter called from Ticker.js currency obj. Related to task T1980.

Test Plan

cd web/cashtab
npm start
mint token, leaving url blank,
ensure auto generated url is correct

Diff Detail

Repository

rABC Bitcoin ABC

Branch

move-var-to-ticker

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17345
Build 34518: Build Diff	cashtab-tests
Build 34517: arc lint + arc unit

Event Timeline

kieran709 created this revision.Nov 24 2021, 17:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2021, 17:54

kieran709 requested review of this revision.Nov 24 2021, 17:54

Harbormaster completed remote builds in B17345: Diff 30997.Nov 24 2021, 17:57

bytesofman accepted this revision.Nov 24 2021, 18:37

This revision is now accepted and ready to land.Nov 24 2021, 18:37

Closed by commit rABC34f8eb9f081a: [Cashtab] move newTokenDocumentUrl to Ticker.js (authored by kieran709). · Explain WhyNov 24 2021, 18:47

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABC34f8eb9f081a: [Cashtab] move newTokenDocumentUrl to Ticker.js.

kieran709 edited the summary of this revision. (Show Details)Nov 24 2021, 22:05

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Common/

Ticker.js

1 line

Tokens/

CreateTokenForm.js

4 lines

Diff 30997

View Options

web/cashtab/src/components/Common/Ticker.js