Differential D10548

[Cashtab] Add support for Philippine Peso
ClosedPublic
Actions

Authored by kieran709 on Nov 25 2021, 17:21.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC8e41edc3f5dc: [Cashtab] Add support for Philippine Peso

Summary

Added Philippine Peso in fiatCurrencies array & object in Ticker.js. Related to task T1989.

Test Plan

npm start
cd web/cashtab
navigate to configure page
select Philippine Peso in the Fiat Currency dropdown
ensure fiat is set to Philippine Peso & that conversion is taking place

Diff Detail

Repository

rABC Bitcoin ABC

Branch

philippine-peso-support

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17375
Build 34578: Build Diff	cashtab-tests
Build 34577: arc lint + arc unit

Event Timeline

kieran709 created this revision.Nov 25 2021, 17:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2021, 17:21

kieran709 requested review of this revision.Nov 25 2021, 17:21

Harbormaster completed remote builds in B17375: Diff 31048.Nov 25 2021, 17:25

bytesofman accepted this revision.Nov 25 2021, 17:46

This revision is now accepted and ready to land.Nov 25 2021, 17:46

Closed by commit rABC8e41edc3f5dc: [Cashtab] Add support for Philippine Peso (authored by kieran709). · Explain WhyNov 25 2021, 17:47

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABC8e41edc3f5dc: [Cashtab] Add support for Philippine Peso.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Common/

Ticker.js

2 lines

Diff 31048

View Options

web/cashtab/src/components/Common/Ticker.js

[Cashtab] Add support for Philippine PesoClosedPublicActions