Summary: make check will generate wallet.backup file on OSX, ignore it.
ClosedPublic
Actions

Authored by andychen on Jan 31 2018, 04:49.

Details

Reviewers

deadalnix
matiu

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGc7ebb3be323a: Summary: make check will generate wallet.backup file on OSX, ignore it.
rABCc7ebb3be323a: Summary: make check will generate wallet.backup file on OSX, ignore it.

Test Plan

N/A

Diff Detail

Repository

rABC Bitcoin ABC

Branch

feature/ignore_wallet_backup

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1785
Build 1785: arc lint + arc unit

Event Timeline

andychen created this revision.Jan 31 2018, 04:49

Owners added a reviewer: Restricted Owners Package.Jan 31 2018, 04:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 31 2018, 04:49

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

matiu accepted this revision.Jan 31 2018, 13:27

This revision is now accepted and ready to land.Jan 31 2018, 13:27

Hi @andychen , JIC, you need to land this changes. See https://github.com/Bitcoin-ABC/bitcoin-abc/blob/master/CONTRIBUTING.md#working-with-the-bitcoin-abc-repository

Closed by commit rABCc7ebb3be323a: Summary: make check will generate wallet.backup file on OSX, ignore it. (authored by andychen). · Explain WhyFeb 1 2018, 03:38

This revision was automatically updated to reflect the committed changes.

done, I checked the contribution.md before coding, if anything I missed, remind me please, thanks :)

Revision Contents
Changeset List

Path

Size

.gitignore

1 line

Diff 2777

View Options

Summary: make check will generate wallet.backup file on OSX, ignore it.ClosedPublicActions