Page MenuHomePhabricator
Differential D10560

test: Move (dis)?connect_nodes globals into TestFramework
ClosedPublic
Actions

Authored by PiRK on Nov 26 2021, 13:39.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCd87a16fbc2d0: test: Move (dis)?connect_nodes globals into TestFramework
Summary

There is now only one callsite for these functions, so we can just move the code where it is needed.

I deviated from the original commit by not creating the ..._helper functions. It doesn't make much sense to define local functions that are used only once and immediately after being defined.

This is a backport of core#19967 [3/3]
https://github.com/bitcoin/bitcoin/pull/19967/commits/3c7d9ab8c8ec5284cdad1a53ee310b79b931f12f

Depends on D10558 and D10559

Test Plan

ninja check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 26 2021, 13:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2021, 13:39
PiRK requested review of this revision.Nov 26 2021, 13:39
teamcity edited the summary of this revision. (Show Details)Nov 26 2021, 13:40
PiRK edited the summary of this revision. (Show Details)Nov 26 2021, 13:54
PiRK added parent revisions: D10559: test: Replace (dis)?connect_nodes globals with TestFramework methods, D10558: test: Replace use of (dis)?connect_nodes globals.
Harbormaster completed remote builds in B17393: Diff 31068.Nov 26 2021, 14:00
PiRK updated this revision to Diff 31071.Nov 26 2021, 14:02

I forgot to remove the functions in util.py

Harbormaster completed remote builds in B17396: Diff 31071.Nov 26 2021, 14:18
Fabien accepted this revision.Nov 29 2021, 08:44
This revision is now accepted and ready to land.Nov 29 2021, 08:44
Closed by commit rABCd87a16fbc2d0: test: Move (dis)?connect_nodes globals into TestFramework (authored by PiRK). · Explain WhyNov 29 2021, 13:08
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCd87a16fbc2d0: test: Move (dis)?connect_nodes globals into TestFramework.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
51 lines
46 lines

Diff 31136

View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...