Page MenuHomePhabricator
Differential D10582

[avalanche] Move the ProofPool definition to its own header
ClosedPublic
Actions

Authored by Fabien on Nov 27 2021, 00:06.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCf8e258013f61: [avalanche] Move the ProofPool definition to its own header
Summary

It will next be turned into a class so we can add methods like addProof and removeProof. There is no change in behavior.

Ref T1854.

Test Plan
ninja all check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 27 2021, 00:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2021, 00:06
Fabien requested review of this revision.Nov 27 2021, 00:06
Fabien added a child revision: D10522: [avalanche] Add wrappers to add and remove a proof from a proof pool.Nov 27 2021, 00:12
Harbormaster completed remote builds in B17423: Diff 31118.Nov 27 2021, 00:22
deadalnix accepted this revision.Nov 29 2021, 22:03
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/avalanche/proofpool.h
29 ↗(On Diff #31118)

I should have caught up on this, but because you are capturing this, you might as well take by value.

30 ↗(On Diff #31118)

and move here.

This revision is now accepted and ready to land.Nov 29 2021, 22:03
Closed by commit rABCf8e258013f61: [avalanche] Move the ProofPool definition to its own header (authored by Fabien). · Explain WhyNov 30 2021, 08:22
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf8e258013f61: [avalanche] Move the ProofPool definition to its own header.

Revision Contents
Changeset List

PathSize
src/
avalanche/
40 lines
63 lines

Diff 31163

View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/proofpool.h

Loading...