Page MenuHomePhabricator

build: remove mingw linker workaround from win gitian descriptor
ClosedPublic

Authored by PiRK on Nov 29 2021, 14:31.

Details

Summary

This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (#6900).
However, it should no longer be required, as we have switched to Bionic (#13171), and that
has a far newer version of binutils.

binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192

Bitcoin ABC now uses Debian Buster, which has an even more recent version of binutils (2.31 vs 2.30).

This is a backport of core#16667

Depends on D10584

Test Plan

@bot gitian-win

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Nov 29 2021, 14:31

Tail of the build log:

[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/31147 -> phabricator/diff/31147
[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/31148 -> phabricator/diff/31148
[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/31149 -> phabricator/diff/31149
[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/31150 -> phabricator/diff/31150
[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/31152 -> phabricator/diff/31152
[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/31160 -> phabricator/diff/31160
[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/31164 -> phabricator/diff/31164
[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/31165 -> phabricator/diff/31165
[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/31166 -> phabricator/diff/31166
[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/31167 -> phabricator/diff/31167
[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/31168 -> phabricator/diff/31168
[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/31169 -> phabricator/diff/31169
[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/31170 -> phabricator/diff/31170
[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/31171 -> phabricator/diff/31171
[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/31172 -> phabricator/diff/31172
[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/8992  -> phabricator/diff/8992
[15:14:46] :	 [Step 1/1]  * [new tag]             phabricator/diff/8993  -> phabricator/diff/8993
[15:14:46] :	 [Step 1/1]  * [new branch]          master                 -> master
[15:14:46] :	 [Step 1/1] --- Building for buster amd64 ---
[15:14:46] :	 [Step 1/1] Stopping target if it is up
[15:14:46] :	 [Step 1/1] Error response from daemon: No such container: gitian-target
[15:14:46] :	 [Step 1/1] Error: No such container: gitian-target
[15:14:46] :	 [Step 1/1] Making a new image copy
[15:14:46] :	 [Step 1/1] Starting target
[15:14:46] :	 [Step 1/1] Checking if target is up.
[15:14:46] :	 [Step 1/1] Preparing build environment
[15:14:46] :	 [Step 1/1] Adding repositories to the sources list (log in var/install.log)
[15:14:46] :	 [Step 1/1] Updating apt-get repository (log in var/install.log)
[15:14:46] :	 [Step 1/1] Installing additional packages (log in var/install.log)
[15:14:46] :	 [Step 1/1] Installing additional packages from repository buster-backports (log in var/install.log)
[15:14:46] :	 [Step 1/1] Upgrading system, may take a while (log in var/install.log)
[15:14:46] :	 [Step 1/1] Creating package manifest
[15:14:46] :	 [Step 1/1] Creating build script (var/build-script)
[15:14:46] :	 [Step 1/1] Running build script (log in var/build.log)
[15:14:46] :	 [Step 1/1] ./bin/gbuild:23:in `system!': failed to run on-target setarch x86_64 bash -x < var/build-script > var/build.log 2>&1 (RuntimeError)
[15:14:46] :	 [Step 1/1] 	from ./bin/gbuild:185:in `build_one_configuration'
[15:14:46] :	 [Step 1/1] 	from ./bin/gbuild:339:in `block (2 levels) in <main>'
[15:14:46] :	 [Step 1/1] 	from ./bin/gbuild:334:in `each'
[15:14:46] :	 [Step 1/1] 	from ./bin/gbuild:334:in `block in <main>'
[15:14:46] :	 [Step 1/1] 	from ./bin/gbuild:332:in `each'
[15:14:46] :	 [Step 1/1] 	from ./bin/gbuild:332:in `<main>'
[15:14:46] :	 [Step 1/1] Build gitian-win failed with exit code 1
[15:14:46]W:	 [Step 1/1] Process exited with code 1
[15:14:46]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
[15:14:46] :	 [Step 1/1] Waiting for 1 service processes to complete
[15:14:47]E:	 [Step 1/1] Ant JUnit report watcher
[15:14:47]E:		 [Ant JUnit report watcher] No reports found for paths:
[15:14:47]E:		 [Ant JUnit report watcher] /home/teamcity/buildAgent/work/jailed-build/results/artifacts/junit/*.xml
[15:14:47]E:	 [Step 1/1] Step Command Line failed
[15:14:47]E: Ant JUnit report watcher
[15:14:47]E:	 [Ant JUnit report watcher] No reports found for paths:
[15:14:47]E:	 [Ant JUnit report watcher] +:results/test_bitcoin.xml
[15:14:47]E:	 [Ant JUnit report watcher] +:results/**/junit_results*.xml
[15:14:47] : Publishing internal artifacts (4s)
[15:14:52] :	 [Publishing internal artifacts] Publishing 1 file using [WebPublisher]
[15:14:52] :	 [Publishing internal artifacts] Publishing 1 file using [ArtifactsCachePublisher]
[15:14:47]W: Publishing artifacts (4s)
[15:14:47] :	 [Publishing artifacts] Collecting files to publish: [+:results/**/junit_results*.xml]
[15:14:47]W:	 [Publishing artifacts] Artifacts path 'results/**/junit_results*.xml' not found
[15:14:52] : Build finished
Fabien requested changes to this revision.Nov 30 2021, 15:23

This is either missing a rebase or not working

This revision now requires changes to proceed.Nov 30 2021, 15:23

remove duplicated lines

@bot gitian-win

This revision is now accepted and ready to land.Dec 1 2021, 09:14