[Cashtab] capitalize notification components names
AbandonedPublic
Actions

Authored by kieran709 on Nov 29 2021, 15:31.

Details

Reviewers

Group Reviewers

Restricted Project

Summary

In order to meet react guidelines, components inside the Notifications.js folder have had their names properly capitalized.

Test Plan

Ensure exports and imports related to Notifications.js are appropriately capitalized.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

notification-syntax-correction

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17443
Build 34714: Build Diff	cashtab-tests
Build 34713: arc lint + arc unit

Event Timeline

kieran709 created this revision.Nov 29 2021, 15:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 29 2021, 15:31

kieran709 requested review of this revision.Nov 29 2021, 15:31

Harbormaster completed remote builds in B17443: Diff 31146.Nov 29 2021, 15:41

Because these are simple functions and not screens and/or JSX, please leave them lowercase. Per earlier Telegram convo, this was corrected by installing eslint. Let me know if there is still some other issue this addresses -- otherwise please abandon. Thanks.

This revision now requires changes to proceed.Nov 29 2021, 20:01

Abandoning per review feedback.