Page MenuHomePhabricator
Differential D10598

[avalanche] Add a rescan method to the ProofPool
ClosedPublic
Actions

Authored by Fabien on Nov 30 2021, 10:32.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC16b231471426: [avalanche] Add a rescan method to the ProofPool
Summary

Similar to what is done in the OrphanProofPool, with a test.

Ref T1854.

Test Plan
ninja all check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 30 2021, 10:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2021, 10:32
Fabien requested review of this revision.Nov 30 2021, 10:32
Fabien mentioned this in D10523: [avalanche] Use the ProofPool multi index to store the orphan proofs.Nov 30 2021, 10:47
Fabien added a child revision: D10523: [avalanche] Use the ProofPool multi index to store the orphan proofs.Nov 30 2021, 10:47
Harbormaster completed remote builds in B17458: Diff 31166.Nov 30 2021, 10:48
deadalnix accepted this revision.Nov 30 2021, 16:50
This revision is now accepted and ready to land.Nov 30 2021, 16:50
deadalnix added a comment.EditedNov 30 2021, 16:50

The dependencies are almost certainly wrong here. This could go in fairly quickly.

Fabien added a comment.Nov 30 2021, 19:14

I need the pool.size() method in the test that is from the dependency, but I can easily reverse order them

Fabien updated this revision to Diff 31182.Nov 30 2021, 19:22

Rebase on master, remove the dependency to D10597.

Fabien edited the summary of this revision. (Show Details)Nov 30 2021, 19:24
Fabien removed a parent revision: D10597: [avalanche] Make the proof pool internal container private.
Fabien added a child revision: D10597: [avalanche] Make the proof pool internal container private.Nov 30 2021, 19:46
Fabien mentioned this in D10597: [avalanche] Make the proof pool internal container private.
Harbormaster completed remote builds in B17466: Diff 31182.Nov 30 2021, 19:54
Fabien removed a child revision: D10523: [avalanche] Use the ProofPool multi index to store the orphan proofs.Nov 30 2021, 19:56
Closed by commit rABC16b231471426: [avalanche] Add a rescan method to the ProofPool (authored by Fabien). · Explain WhyNov 30 2021, 19:57
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC16b231471426: [avalanche] Add a rescan method to the ProofPool.
Fabien removed a child revision: D10597: [avalanche] Make the proof pool internal container private.Dec 1 2021, 15:01

Revision Contents
Changeset List

PathSize
src/
avalanche/
4 lines
11 lines
test/
31 lines
test/
lint/
1 line

Diff 31185

View Options

src/avalanche/proofpool.h

Loading...
View Options

src/avalanche/proofpool.cpp

Loading...
View Options

src/avalanche/test/proofpool_tests.cpp

Loading...
View Options

test/lint/lint-circular-dependencies.sh

Loading...