Page MenuHomePhabricator
Differential D10597

[avalanche] Make the proof pool internal container private
ClosedPublic
Actions

Authored by Fabien on Nov 30 2021, 10:24.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCf24fb87ca0c4: [avalanche] Make the proof pool internal container private
Summary

This adds the missing accessors for keeping the multi index container private.

Ref T1854.

Depends on D10603.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 30 2021, 10:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2021, 10:24
Fabien requested review of this revision.Nov 30 2021, 10:24
Fabien added a child revision: D10598: [avalanche] Add a rescan method to the ProofPool.Nov 30 2021, 10:32
Harbormaster completed remote builds in B17457: Diff 31165.Nov 30 2021, 10:39
deadalnix requested changes to this revision.Nov 30 2021, 16:46
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/avalanche/peermanager.cpp
422 ↗(On Diff #31165)

You should check for identity here. I guess this problem was introduced when moving from a value type to a reference type for proofs.

src/avalanche/proofpool.cpp
7 ↗(On Diff #31165)

This does nto seems necessary.

This revision now requires changes to proceed.Nov 30 2021, 16:46
Fabien removed a child revision: D10598: [avalanche] Add a rescan method to the ProofPool.Nov 30 2021, 19:24
Fabien updated this revision to Diff 31183.EditedNov 30 2021, 19:45

Rebase on top of D10598, remove unecessary header

Fabien planned changes to this revision.Nov 30 2021, 19:46
Fabien edited the summary of this revision. (Show Details)
Fabien edited the summary of this revision. (Show Details)
Fabien added a parent revision: D10598: [avalanche] Add a rescan method to the ProofPool.
Fabien edited the summary of this revision. (Show Details)
Fabien added a task: Restricted Maniphest Task.
Fabien removed a parent revision: D10586: [avalanche] Add a ProofPool getProof accessor to retrieve a proof from its id.
Fabien mentioned this in D10523: [avalanche] Use the ProofPool multi index to store the orphan proofs.Nov 30 2021, 19:54
Fabien added a child revision: D10523: [avalanche] Use the ProofPool multi index to store the orphan proofs.Nov 30 2021, 19:55
Harbormaster completed remote builds in B17467: Diff 31183.Nov 30 2021, 20:04
Fabien updated this revision to Diff 31186.Nov 30 2021, 20:10

Check the peer and pool proofs are the same pointer, not only the same id

Harbormaster completed remote builds in B17469: Diff 31186.Nov 30 2021, 20:37
deadalnix requested changes to this revision.Dec 1 2021, 14:01
deadalnix added inline comments.
src/avalanche/peermanager.cpp
419 ↗(On Diff #31186)

This should probably go on its own ASAP.

src/avalanche/proofpool.h
19 ↗(On Diff #31186)

1/ this was already used, so adding it doesn't seems like it shoudl be necessary.
2/ Isn't it included as part of primitives/transaction.h anyways?

61 ↗(On Diff #31186)

Where is this declared?

This revision now requires changes to proceed.Dec 1 2021, 14:01
Fabien added inline comments.Dec 1 2021, 14:47
src/avalanche/proofpool.h
19 ↗(On Diff #31186)

Yes and yes, I completely missed it

61 ↗(On Diff #31186)

This is in coins.h

Fabien updated this revision to Diff 31208.Dec 1 2021, 15:00

Rebase on top of D10603 and remove the useless COutPoint class forwarding

Fabien edited the summary of this revision. (Show Details)Dec 1 2021, 15:01
Fabien added a parent revision: D10603: [avalanche] Improve the peer manager verify() method.
Fabien removed a parent revision: D10598: [avalanche] Add a rescan method to the ProofPool.
Harbormaster completed remote builds in B17490: Diff 31208.Dec 1 2021, 15:12
deadalnix accepted this revision.Dec 3 2021, 19:49
This revision is now accepted and ready to land.Dec 3 2021, 19:49
Closed by commit rABCf24fb87ca0c4: [avalanche] Make the proof pool internal container private (authored by Fabien). · Explain WhyDec 3 2021, 23:49
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf24fb87ca0c4: [avalanche] Make the proof pool internal container private.

Revision Contents
Changeset List

PathSize
src/
avalanche/
18 lines
6 lines
5 lines
test/
6 lines

Diff 31262

View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/proofpool.h

Loading...
View Options

src/avalanche/proofpool.cpp

Loading...
View Options

src/avalanche/test/proofpool_tests.cpp

Loading...