Page MenuHomePhabricator

[avalanche] Make the proof pool internal container private
ClosedPublic

Authored by Fabien on Nov 30 2021, 10:24.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCf24fb87ca0c4: [avalanche] Make the proof pool internal container private
Summary

This adds the missing accessors for keeping the multi index container private.

Ref T1854.

Depends on D10603.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_proofpool_privatepool
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17457
Build 34742: Build Diffbuild-clang · build-diff · lint-circular-dependencies · build-without-wallet · build-debug · build-clang-tidy
Build 34741: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Nov 30 2021, 10:24
deadalnix requested changes to this revision.Nov 30 2021, 16:46
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/avalanche/peermanager.cpp
422

You should check for identity here. I guess this problem was introduced when moving from a value type to a reference type for proofs.

src/avalanche/proofpool.cpp
7

This does nto seems necessary.

This revision now requires changes to proceed.Nov 30 2021, 16:46

Rebase on top of D10598, remove unecessary header

Fabien planned changes to this revision.Nov 30 2021, 19:46
Fabien edited the summary of this revision. (Show Details)
Fabien edited the summary of this revision. (Show Details)
Fabien edited the summary of this revision. (Show Details)
Fabien added a task: Restricted Maniphest Task.

Check the peer and pool proofs are the same pointer, not only the same id

deadalnix requested changes to this revision.Dec 1 2021, 14:01
deadalnix added inline comments.
src/avalanche/peermanager.cpp
419 ↗(On Diff #31186)

This should probably go on its own ASAP.

src/avalanche/proofpool.h
19 ↗(On Diff #31186)

1/ this was already used, so adding it doesn't seems like it shoudl be necessary.
2/ Isn't it included as part of primitives/transaction.h anyways?

61 ↗(On Diff #31186)

Where is this declared?

This revision now requires changes to proceed.Dec 1 2021, 14:01
src/avalanche/proofpool.h
19 ↗(On Diff #31186)

Yes and yes, I completely missed it

61 ↗(On Diff #31186)

This is in coins.h

Rebase on top of D10603 and remove the useless COutPoint class forwarding

This revision is now accepted and ready to land.Dec 3 2021, 19:49