Differential D10660

[avalanche] Select the favorite conflicting proof
ClosedPublic
Actions

Authored by Fabien on Dec 9 2021, 17:01.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC25c8ddf8632c: [avalanche] Select the favorite conflicting proof

Summary

This diff selects the favorite between 2 proofs from the conflicting pool.

Ref T1854.

Depends on D10651 and D10658.

Test Plan

ninja all check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_preferred_conflicting_proof

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17607
Build 35040: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 35039: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 9 2021, 17:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 9 2021, 17:02

Fabien requested review of this revision.Dec 9 2021, 17:02

Harbormaster completed remote builds in B17598: Diff 31344.Dec 9 2021, 17:18

Rebase

Harbormaster completed remote builds in B17607: Diff 31353.Dec 10 2021, 13:50

The behavior changed, and yet no test changed. This indicates to me the current behavior is not tested appropriately. This is the first step that needs to be taken here.

This revision now requires changes to proceed.Dec 10 2021, 16:36

Fabien mentioned this in D10658: [avalanche] Create a conflicting proof pool.Dec 11 2021, 12:26

Rebase after D10658 added a test for the previous behavior, so it only needs to be updated.

Harbormaster completed remote builds in B17617: Diff 31368.Dec 11 2021, 12:52

deadalnix accepted this revision.Dec 12 2021, 22:19

This revision is now accepted and ready to land.Dec 12 2021, 22:19

Closed by commit rABC25c8ddf8632c: [avalanche] Select the favorite conflicting proof (authored by Fabien). · Explain WhyDec 13 2021, 09:20

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC25c8ddf8632c: [avalanche] Select the favorite conflicting proof.