Differential D10674

Refactor ProofPool::addProofIfPreferred
ClosedPublic
Actions

Authored by deadalnix on Dec 14 2021, 19:46.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCfa6a6071853b: Refactor ProofPool::addProofIfPreferred

Summary

This reduce nesting and reliance on state.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

proofpoolrefac

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17634
Build 35094: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35093: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 14 2021, 19:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 14 2021, 19:46

deadalnix requested review of this revision.Dec 14 2021, 19:46

Harbormaster completed remote builds in B17634: Diff 31401.Dec 14 2021, 20:20

Fabien accepted this revision.Dec 14 2021, 20:38

This revision is now accepted and ready to land.Dec 14 2021, 20:38

Closed by commit rABCfa6a6071853b: Refactor ProofPool::addProofIfPreferred (authored by deadalnix). · Explain WhyDec 15 2021, 17:13

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCfa6a6071853b: Refactor ProofPool::addProofIfPreferred.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

proofpool.cpp

20 lines

Diff 31401

View Options

src/avalanche/proofpool.cpp

Refactor ProofPool::addProofIfPreferredClosedPublicActions