Paths

Table of Contentst

Differential D10680

qt: Add WalletFrame::sizeHint
ClosedPublic
Actions

Authored by PiRK on Dec 15 2021, 08:32.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCd6d1e97c43d2: qt: Add WalletFrame::sizeHint

Summary

This change makes the layout of a WalletFrame widget correct even without loaded wallets.
Previously, the window was very small, and as a result the progress dialog overlay was invisible.

This is a backport of core-gui#116

Test Plan

src/qt/bitcoin-qt -regtest -resetguisettings -nowallet

Diff Detail

Repository

rABC Bitcoin ABC

Branch

gui_pr116

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17641
Build 35108: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35107: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 15 2021, 08:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 15 2021, 08:32

PiRK requested review of this revision.Dec 15 2021, 08:32

teamcity edited the summary of this revision. (Show Details)Dec 15 2021, 08:33

Bug demo: (click to show animation)

Peek 2021-12-15 09-30_downscaled.gif (313×474 px, 278 KB)

Harbormaster completed remote builds in B17641: Diff 31409.Dec 15 2021, 08:49

Fabien accepted this revision.Dec 15 2021, 14:12

This revision is now accepted and ready to land.Dec 15 2021, 14:12

Closed by commit rABCd6d1e97c43d2: qt: Add WalletFrame::sizeHint (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyDec 15 2021, 15:57

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCd6d1e97c43d2: qt: Add WalletFrame::sizeHint.

Revision Contents
Changeset List

Path

Size

src/

qt/

4 lines

walletframe.cpp

8 lines

Diff 31409

src/qt/walletframe.h

Loading...

src/qt/walletframe.cpp

Loading...