Paths

Table of Contentst

Differential D10681

p2p: don't add AlreadyHave transactions to recentRejects
ClosedPublic
Actions

Authored by PiRK on Dec 15 2021, 09:44.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1371b60fd052: p2p: don't add AlreadyHave transactions to recentRejects

Summary

Now, we only add a transaction to our recentRejects filter if we didn't already have it, meaning that it is added at most once, as intended.

This is a backport of core#19753

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 15 2021, 09:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 15 2021, 09:44

PiRK requested review of this revision.Dec 15 2021, 09:44

teamcity edited the summary of this revision. (Show Details)Dec 15 2021, 09:45

teamcity edited the summary of this revision. (Show Details)Dec 15 2021, 09:50

Harbormaster completed remote builds in B17642: Diff 31410.Dec 15 2021, 09:55

Fabien accepted this revision.Dec 15 2021, 14:26

This revision is now accepted and ready to land.Dec 15 2021, 14:26

PiRK edited the summary of this revision. (Show Details)Dec 15 2021, 15:55

Closed by commit rABC1371b60fd052: p2p: don't add AlreadyHave transactions to recentRejects (authored by PiRK). · Explain WhyDec 15 2021, 15:57

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1371b60fd052: p2p: don't add AlreadyHave transactions to recentRejects.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

42 lines

test/

functional/

p2p_permissions.py

10 lines

Diff 31425

View Options

src/net_processing.cpp