Page MenuHomePhabricator
Differential D10723

tests: increase timeout in getnettotals test
ClosedPublic
Actions

Authored by PiRK on Dec 22 2021, 12:53.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2228b24e18a6: tests: increase timeout in getnettotals test
Summary

We saw test failure in a CI run, because the time between the first ping and the last pong was about 4 seconds and the response for getnettotals was not up to date after one second.
Bumping the timeouts from 1 s to 10 s should allow the nodes to synchronize their states and make the test more reliable when it is run on a slow system.

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rpc_net_timeout
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17728
Build 35282: Build Diffbuild-clang · build-without-wallet · build-clang-tidy · build-diff · build-debug
Build 35281: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 22 2021, 12:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 22 2021, 12:53
PiRK requested review of this revision.Dec 22 2021, 12:53
PiRK edited the summary of this revision. (Show Details)Dec 22 2021, 12:55
Harbormaster completed remote builds in B17728: Diff 31533.Dec 22 2021, 13:08
PiRK updated this revision to Diff 31534.Dec 22 2021, 13:13
PiRK edited the summary of this revision. (Show Details)

Bump all 4 timeouts. The delay could also happen because of the second node.

Harbormaster completed remote builds in B17729: Diff 31534.Dec 22 2021, 13:25
Fabien accepted this revision.Dec 22 2021, 14:32
This revision is now accepted and ready to land.Dec 22 2021, 14:32
Closed by commit rABC2228b24e18a6: tests: increase timeout in getnettotals test (authored by PiRK). · Explain WhyDec 22 2021, 15:09
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC2228b24e18a6: tests: increase timeout in getnettotals test.

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines

Diff 31533

View Options

test/functional/rpc_net.py

Loading...