tests: Remove no longer needed UBSan suppressions
ClosedPublic
Actions

Authored by PiRK on Dec 22 2021, 17:01.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC6294e47f793b: tests: Remove no longer needed UBSan suppressions

Summary

core#20379

Remove no longer needed UBSan suppression.
The float divide-by-zero in validation.cpp was fixed by instagibbs in D8857.

The other suppression was removed by core#19630 after fixing fee estimation code that does not exist in Bitcoin ABC. We can assume that we do not need this suppression, and add it back if needed.

This is a backport of core#20379

Test Plan

With UBSAN:
ninja && ninja check check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Dec 22 2021, 17:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 22 2021, 17:01

PiRK requested review of this revision.Dec 22 2021, 17:01

teamcity edited the summary of this revision. (Show Details)Dec 22 2021, 17:01

Harbormaster completed remote builds in B17735: Diff 31547.Dec 22 2021, 17:12

@bot build-ubsan

teamcity awarded a token.Dec 22 2021, 17:34

Fabien accepted this revision.Dec 22 2021, 17:45

This revision is now accepted and ready to land.Dec 22 2021, 17:45

Closed by commit rABC6294e47f793b: tests: Remove no longer needed UBSan suppressions (authored by PiRK). · Explain WhyDec 23 2021, 13:49

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC6294e47f793b: tests: Remove no longer needed UBSan suppressions.

Revision Contents
Changeset List

Path

Size

test/

sanitizer_suppressions/

ubsan

4 lines

Diff 31565

View Options

test/sanitizer_suppressions/ubsan

tests: Remove no longer needed UBSan suppressionsClosedPublicActions