Fix UB with bench on genesis block
ClosedPublic
Actions

Authored by PiRK on Jan 8 2021, 22:40.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABCad59559de161: Fix UB with bench on genesis block

Summary

During the loading of the genesis block, the bench print lines in ConnectTip divide by zero due to early return in ConnectBlock.

Increment nBlocksTotal before returning in ConnectBlock

This is a backport of Core PR15283

Test Plan

ninja && ./src/bitcoind -debug=bench | grep "Connect total:"

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jan 8 2021, 22:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 8 2021, 22:40

PiRK requested review of this revision.Jan 8 2021, 22:40

teamcity edited the summary of this revision. (Show Details)Jan 8 2021, 22:41

Harbormaster completed remote builds in B14679: Diff 26812.Jan 8 2021, 22:56

majcosta accepted this revision.Jan 9 2021, 05:13

This revision is now accepted and ready to land.Jan 9 2021, 05:13

Closed by commit rABCad59559de161: Fix UB with bench on genesis block (authored by Gregory Sanders <gsanders87@gmail.com>, committed by PiRK). · Explain WhyJan 9 2021, 14:03

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCad59559de161: Fix UB with bench on genesis block.

PiRK mentioned this in D10728: tests: Remove no longer needed UBSan suppressions.Dec 22 2021, 17:01

PiRK mentioned this in rABC6294e47f793b: tests: Remove no longer needed UBSan suppressions.Dec 23 2021, 13:49

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

5 lines

Diff 26818

View Options

Fix UB with bench on genesis blockClosedPublicActions