Differential D10729

[Cashtab] Replace hardcoded param with variable
ClosedPublic
Actions

Authored by kieran709 on Dec 22 2021, 21:56.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCe1944dfa1519: [Cashtab] Replace hardcoded param with variable

Summary

Removed two insances of 5.5 hardcoded in Send.js and replaced them with fromSmallestDenomination(clurrency.dustSats). Related to task T2107.

Test Plan

npm web/cashtab && npm start
Use the reply message link and ensure that the amount input on the send form is 5.5.
Input an amount less than 5.5 in the amount input and ensure the error message indicates that you need to send at least 5.5 XEC.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

replace-hardcoded-param-sendjs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17737
Build 35300: Build Diff	cashtab-tests
Build 35299: arc lint + arc unit

Event Timeline

kieran709 created this revision.Dec 22 2021, 21:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 22 2021, 21:56

kieran709 requested review of this revision.Dec 22 2021, 21:56

Harbormaster completed remote builds in B17737: Diff 31550.Dec 22 2021, 21:59

bytesofman accepted this revision.Dec 29 2021, 18:14

This revision is now accepted and ready to land.Dec 29 2021, 18:14

Closed by commit rABCe1944dfa1519: [Cashtab] Replace hardcoded param with variable (authored by kieran709). · Explain WhyDec 30 2021, 17:38

This revision was automatically updated to reflect the committed changes.

kieran709 added a commit: rABCe1944dfa1519: [Cashtab] Replace hardcoded param with variable.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Send/

Send.js

7 lines

Diff 31550

View Options

web/cashtab/src/components/Send/Send.js

[Cashtab] Replace hardcoded param with variableClosedPublicActions